From 2e224f197c6844d31bdb94f727278050192492b4 Mon Sep 17 00:00:00 2001 From: Stefan Berger Date: Mon, 4 Oct 2010 06:34:05 -0400 Subject: [PATCH] nwfilter: fix memory leaks Fixing memory leak shown by valgrind and freeing buffer in two more places. --- src/nwfilter/nwfilter_ebiptables_driver.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index bdd5c79054..3fbe08b05f 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -1508,7 +1508,11 @@ _iptablesCreateRuleInstance(int directionIn, } if (virBufferUse(&prefix)) { - virBufferVSprintf(&prefix, "%s", virBufferContentAndReset(&buf)); + char *s = virBufferContentAndReset(&buf); + + virBufferAdd(&prefix, s, -1); + + VIR_FREE(s); final = &prefix; @@ -1531,11 +1535,13 @@ _iptablesCreateRuleInstance(int directionIn, err_exit: virBufferFreeAndReset(&buf); + virBufferFreeAndReset(&prefix); return -1; exit_no_error: virBufferFreeAndReset(&buf); + virBufferFreeAndReset(&prefix); return 0; }