openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix issue of PF brought down if VF is 8021.Qbh and pci passthrough 

If a 8021.Qbh network device supports SRIOV and its VF is being used
in pci passthrough mode, when the guest is shutdown or destroyed, the
PF inteface is also brought down. qemuDomainHostdevNetConfigRestore()
finds out the PF for provided hostdev (which is VF) and passes it to
virNetDevPortProfileDisassociate() as linkdev. Later, linkdev gets passed
to virNetDevSetOnline() where the interface is brought down by clearing
IFF_UP flag.

Bringing down a PF, when only VF is being brought down is not expected
behavior. This patch adds a check so that virNetDevSetOnline() is called
only for PF and not if device is a VF.

Signed-off-by: Nishank Trivedi <nistrive@cisco.com>
This commit is contained in:
Nishank Trivedi 2012-08-30 15:27:27 -04:00 committed by Stefan Berger
parent 9e995c9a23
commit 3044433f29
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -261,6 +261,7 @@ Patches have also been contributed by:
J.B. Joret <jb@linux.vnet.ibm.com> J.B. Joret <jb@linux.vnet.ibm.com>
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Gene Czarcinski <gene@czarc.net> Gene Czarcinski <gene@czarc.net>
Nishank Trivedi <nistrive@cisco.com>
[....send patches to get your name here....] [....send patches to get your name here....]

3
src/util/virnetdevvportprofile.c
View File

@ -1235,7 +1235,8 @@ virNetDevVPortProfileDisassociate(const char *macvtap_ifname,
/* avoid disassociating twice */ /* avoid disassociating twice */
if (vmOp == VIR_NETDEV_VPORT_PROFILE_OP_MIGRATE_IN_FINISH) if (vmOp == VIR_NETDEV_VPORT_PROFILE_OP_MIGRATE_IN_FINISH)
break; break;
ignore_value(virNetDevSetOnline(linkdev, false)); if (vf < 0)
ignore_value(virNetDevSetOnline(linkdev, false));
rc = virNetDevVPortProfileOp8021Qbh(linkdev, macvtap_macaddr, vf, rc = virNetDevVPortProfileOp8021Qbh(linkdev, macvtap_macaddr, vf,
virtPort, NULL, virtPort, NULL,
VIR_NETDEV_VPORT_PROFILE_LINK_OP_DISASSOCIATE); VIR_NETDEV_VPORT_PROFILE_LINK_OP_DISASSOCIATE);