openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

snapshot: Mention disk-only snapshots in error message 

When a disk-only snapshot is requested the domain is treated as if it
was offline. This forbids to mix memory checkpoints with the DISK_ONLY
flag.

This patch improves the error message and mentions the restriction in
the virsh man page.
This commit is contained in:
Peter Krempa 2013-01-25 11:50:43 +01:00
parent 533cfb4675
commit 366a3d52ee
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/snapshot_conf.c
View File

@ -309,7 +309,8 @@ virDomainSnapshotDefParseString(const char *xmlStr,
if (offline && def->memory &&
def->memory != VIR_DOMAIN_SNAPSHOT_LOCATION_NONE) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("memory state cannot be saved with offline snapshot"));
_("memory state cannot be saved with offline or "
"disk-only snapshot"));
goto cleanup;
}
def->file = memoryFile;

3
tools/virsh.pod
View File

@ -2749,7 +2749,8 @@ The I<--memspec> option can be used to control whether a checkpoint
is internal or external. The I<--memspec> flag is mandatory, followed
by a B<memspec> of the form B<[file=]name[,snapshot=type]>, where
type can be B<none>, B<internal>, or B<external>. To include a literal
comma in B<file=name>, escape it with a second comma.
comma in B<file=name>, escape it with a second comma. I<--memspec> cannot
be used together with I<--disk-only>.
The I<--diskspec> option can be used to control how I<--disk-only> and
external checkpoints create external files. This option can occur