From 382bdbfe7b1d5d359cd47e6d352d7f0b20884165 Mon Sep 17 00:00:00 2001 From: Jie Wang Date: Fri, 9 Jun 2017 17:12:34 +0800 Subject: [PATCH] qemu: Fix memory leak in qemuDomainBlockCopyCommon() Exiting early through the cleanup path did result in 'mirror' being leaked. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1e3c7fca0e..74cc2c45d4 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16856,7 +16856,6 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, endjob: if (need_unlink && unlink(mirror->path)) VIR_WARN("unable to unlink just-created %s", mirror->path); - virStorageSourceFree(mirror); qemuDomainObjEndJob(driver, vm); if (monitor_error) { virSetError(monitor_error); @@ -16866,6 +16865,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, cleanup: VIR_FREE(device); virObjectUnref(cfg); + virStorageSourceFree(mirror); return ret; }