From 461fb5559969c9f8792cff449250eecaf36e4073 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 27 Aug 2014 14:32:27 -0400 Subject: [PATCH] qemu_command: Resolve Coverity RESOURCE_LEAK In qemuParseISCSIString() if an error was returned, then the call to qemuParseDriveURIString() where the uri is free'd wouldn't be run --- src/qemu/qemu_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 8fb81a4356..528f947fa5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2795,6 +2795,7 @@ qemuParseISCSIString(virDomainDiskDefPtr def) virReportError(VIR_ERR_INTERNAL_ERROR, _("invalid name '%s' for iSCSI disk"), def->src->path); + virURIFree(uri); return -1; } }