From 557a96e0f4218d26c1659dc74f7f80bdb509c7ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Tue, 16 Apr 2019 17:36:57 +0100 Subject: [PATCH] network: ensure floor sum is reset to zero when starting networks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In extreme cases libvirt can get mixed up about what VMs are running and attached to a network leading to the cached floor sum value being outdated. When this happens the only option is to destroy the network and then restart libvirtd. If we set floor sum back to zero when starting the network, we avoid the need for a libvirtd restart at least. Reviewed-by: Laine Stump Signed-off-by: Daniel P. Berrangé --- src/network/bridge_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 6e15e43ca6..3008846074 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2826,6 +2826,8 @@ networkStartNetwork(virNetworkDriverStatePtr driver, goto cleanup; } + virNetworkObjSetFloorSum(obj, 0); + /* finally we can call the 'started' hook script if any */ if (networkRunHook(obj, NULL, NULL, VIR_HOOK_NETWORK_OP_STARTED,