From 5a990e0bf3248e4c6bdaebce5d5e2a1e3f310c64 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 7 Apr 2017 17:39:39 +0200 Subject: [PATCH] qemu: migration: Reject migration of an empty disk If you specify disks to migrate it would be possible to select an empty drive for migration. Reject such config. --- src/qemu/qemu_migration.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b3d42619f2..9b3285f302 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -515,9 +515,10 @@ qemuMigrationStartNBDServer(virQEMUDriverPtr driver, if (!qemuMigrateDisk(disk, nmigrate_disks, migrate_disks)) continue; - if (disk->src->readonly) { + if (disk->src->readonly || virStorageSourceIsEmpty(disk->src)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("Cannot migrate read-only disk %s"), disk->dst); + _("Cannot migrate empty or read-only disk %s"), + disk->dst); goto cleanup; }