diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 671ce170e6..d8ad54ac85 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1264,6 +1264,7 @@ <driver name='qemu' type='raw'/> <source dev='/dev/sda'/> <geometry cyls='16383' heads='16' secs='63' trans='lba'/> + <iolimits logical_block_size='512' physical_block_size='4096'/> <target dev='hda' bus='ide'/> </disk> </devices> @@ -1632,6 +1633,23 @@ BIOS-Translation-Modus (none, lba or auto) +
iolimits
+
If present, the iolimits element allows + to override any of the block device properties listed below. + Since 0.10.2 (QEMU and KVM) +
+
logical_block_size
+
The logical block size the disk will report to the guest + OS. For Linux this would be the value returned by the + BLKSSZGET ioctl and describes the smallest units for disk + I/O. +
physical_block_size
+
The physical block size the disk will report to the guest + OS. For Linux this would be the value returned by the + BLKPBSZGET ioctl and describes the disk's hardware sector + size which can be relevant for the alignment of disk data. +
+

Filesystems

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 145caf78d8..60cf33e0f9 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -886,6 +886,9 @@ + + + @@ -1110,6 +1113,20 @@ + + + + + + + + + + + + + + diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 49327dfc0c..faae315c4f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3421,6 +3421,8 @@ virDomainDiskDefParseXML(virCapsPtr caps, char *authUUID = NULL; char *usageType = NULL; char *tray = NULL; + char *logical_block_size = NULL; + char *physical_block_size = NULL; if (VIR_ALLOC(def) < 0) { virReportOOMError(); @@ -3432,6 +3434,9 @@ virDomainDiskDefParseXML(virCapsPtr caps, def->geometry.sectors = 0; def->geometry.trans = VIR_DOMAIN_DISK_TRANS_DEFAULT; + def->iolimits.logical_block_size = 0; + def->iolimits.physical_block_size = 0; + ctxt->node = node; type = virXMLPropString(node, "type"); @@ -3570,6 +3575,27 @@ virDomainDiskDefParseXML(virCapsPtr caps, goto error; } } + } else if (xmlStrEqual(cur->name, BAD_CAST "iolimits")) { + logical_block_size = + virXMLPropString(cur, "logical_block_size"); + if (logical_block_size && + virStrToLong_ui(logical_block_size, NULL, 0, + &def->iolimits.logical_block_size) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("invalid logical block size '%s'"), + logical_block_size); + goto error; + } + physical_block_size = + virXMLPropString(cur, "physical_block_size"); + if (physical_block_size && + virStrToLong_ui(physical_block_size, NULL, 0, + &def->iolimits.physical_block_size) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("invalid physical block size '%s'"), + physical_block_size); + goto error; + } } else if (!driverName && xmlStrEqual(cur->name, BAD_CAST "driver")) { driverName = virXMLPropString(cur, "name"); @@ -4075,6 +4101,8 @@ cleanup: VIR_FREE(serial); virStorageEncryptionFree(encryption); VIR_FREE(startupPolicy); + VIR_FREE(logical_block_size); + VIR_FREE(physical_block_size); ctxt->node = save_ctxt; return def; @@ -11341,6 +11369,26 @@ static void virDomainDiskGeometryDefFormat(virBufferPtr buf, virBufferAddLit(buf, "/>\n"); } } +static void virDomainDiskIolimitsDefFormat(virBufferPtr buf, + virDomainDiskDefPtr def) +{ + if (def->iolimits.logical_block_size > 0 || + def->iolimits.physical_block_size > 0) { + virBufferAddLit(buf," iolimits.logical_block_size > 0) { + virBufferAsprintf(buf, + " logical_block_size='%u'", + def->iolimits.logical_block_size); + } + if (def->iolimits.physical_block_size > 0) { + virBufferAsprintf(buf, + " physical_block_size='%u'", + def->iolimits.physical_block_size); + } + virBufferAddLit(buf, "/>\n"); + } +} + static int virDomainDiskDefFormat(virBufferPtr buf, @@ -11514,6 +11562,7 @@ virDomainDiskDefFormat(virBufferPtr buf, } virDomainDiskGeometryDefFormat(buf, def); + virDomainDiskIolimitsDefFormat(buf, def); /* For now, mirroring is currently output-only: we only output it * for live domains, therefore we ignore it on input except for diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 034bebfa10..0073aa9770 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -569,6 +569,11 @@ struct _virDomainDiskDef { int trans; } geometry; + struct { + unsigned int logical_block_size; + unsigned int physical_block_size; + } iolimits; + virDomainBlockIoTuneInfo blkdeviotune; char *serial;