openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

nwfilter: Fix return value comparison for virNWFilterTriggerVMFilterRebuild 

Should compare < 0 to be correct.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2017-05-25 09:35:58 -04:00
parent d53224b7a5
commit 69979369bb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/virnwfilterobj.c
View File

@ -253,7 +253,7 @@ virNWFilterObjTestUnassignDef(virNWFilterObjPtr obj)
obj->wantRemoved = true; obj->wantRemoved = true;
/* trigger the update on VMs referencing the filter */ /* trigger the update on VMs referencing the filter */
if (virNWFilterTriggerVMFilterRebuild()) if (virNWFilterTriggerVMFilterRebuild() < 0)
rc = -1; rc = -1;
obj->wantRemoved = false; obj->wantRemoved = false;
@ -345,7 +345,7 @@ virNWFilterObjListAssignDef(virNWFilterObjListPtr nwfilters,
obj->newDef = def; obj->newDef = def;
/* trigger the update on VMs referencing the filter */ /* trigger the update on VMs referencing the filter */
if (virNWFilterTriggerVMFilterRebuild()) { if (virNWFilterTriggerVMFilterRebuild() < 0) {
obj->newDef = NULL; obj->newDef = NULL;
virNWFilterObjUnlock(obj); virNWFilterObjUnlock(obj);
return NULL; return NULL;