From 785f9340f64c78a97518992c58df2576aeff2f5d Mon Sep 17 00:00:00 2001 From: Sukrit Bhatnagar Date: Tue, 17 Apr 2018 04:26:25 +0530 Subject: [PATCH] qemu: Escape commas for qemuBuildGraphicsVNCCommandLine Add comma escaping for cfg->vncTLSx509certdir. Signed-off-by: Sukrit Bhatnagar Reviewed-by: John Ferlan --- src/qemu/qemu_command.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 920c48a11a..0252aad3b2 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7657,10 +7657,13 @@ qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfigPtr cfg, if (cfg->vncTLS) { virBufferAddLit(&opt, ",tls"); - if (cfg->vncTLSx509verify) - virBufferAsprintf(&opt, ",x509verify=%s", cfg->vncTLSx509certdir); - else - virBufferAsprintf(&opt, ",x509=%s", cfg->vncTLSx509certdir); + if (cfg->vncTLSx509verify) { + virBufferAddLit(&opt, ",x509verify="); + virQEMUBuildBufferEscapeComma(&opt, cfg->vncTLSx509certdir); + } else { + virBufferAddLit(&opt, ",x509="); + virQEMUBuildBufferEscapeComma(&opt, cfg->vncTLSx509certdir); + } } if (cfg->vncSASL) {