openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

virbitmaptest: Add test for out of bounds condition 

Previous patch fixed an issue where, when parsing a bitmap from the
string, the bounds of the bitmap weren't checked. That flaw resulted into
crashes. This test tests that case to avoid it in the future.
This commit is contained in:
Peter Krempa 2013-08-16 12:13:27 +02:00
parent 536d38128e
commit 7efd5fd1b0
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
tests/virbitmaptest.c
View File

@ -464,6 +464,38 @@ cleanup:
return ret;
}
/* test out of bounds conditions on virBitmapParse */
static int
test9(const void *opaque ATTRIBUTE_UNUSED)
{
int ret = -1;
virBitmapPtr bitmap;
if (virBitmapParse("100000000", 0, &bitmap, 20) != -1)
goto cleanup;
if (bitmap)
goto cleanup;
if (virBitmapParse("1-1000000000", 0, &bitmap, 20) != -1)
goto cleanup;
if (bitmap)
goto cleanup;
if (virBitmapParse("1-10^10000000000", 0, &bitmap, 20) != -1)
goto cleanup;
if (bitmap)
goto cleanup;
ret = 0;
cleanup:
return ret;
}
static int
mymain(void)
{
@ -485,6 +517,8 @@ mymain(void)
ret = -1;
if (virtTestRun("test8", 1, test8, NULL) < 0)
ret = -1;
if (virtTestRun("test9", 1, test9, NULL) < 0)
ret = -1;
return ret;
}