From 874b00f75063eef91a3499da8c89474067995b7c Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 14 Feb 2022 16:51:20 +0100 Subject: [PATCH] qemuhotplugtest: Assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All modern QEMU versions use FD passing for listening unix sockets so the test should reflect this. This will later help when removing the legacy code paths when we drop support for old QEMUs. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- tests/qemuhotplugtest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index ce215da099..eb7f5ed961 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -95,6 +95,7 @@ qemuHotplugCreateObjects(virDomainXMLOption *xmlopt, virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_SCSI_BLOCK); virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_DEVICE_USB_KBD); virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_NETDEV_VHOST_VDPA); + virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE); if (qemuTestCapsCacheInsert(driver.qemuCapsCache, priv->qemuCaps) < 0) return -1; @@ -764,6 +765,7 @@ mymain(void) "object-del", QMP_OK); DO_TEST_ATTACH("base-live", "qemu-agent", false, true, + "getfd", QMP_OK, "chardev-add", QMP_OK, "device_add", QMP_OK); DO_TEST_DETACH("base-live", "qemu-agent-detach", false, false, @@ -856,6 +858,7 @@ mymain(void) "device_del", QMP_DEVICE_DELETED("ua-UserWatchdog") QMP_OK); DO_TEST_ATTACH("base-live", "guestfwd", false, true, + "getfd", QMP_OK, "chardev-add", QMP_OK, "netdev_add", QMP_OK); DO_TEST_DETACH("base-live", "guestfwd", false, false,