openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

lxc: Clang is complaining about possible NULL pointer. 

The array "mount" inside lxc_container is not being checked before for
loop. Clang syntax scan is complaining about this segmentation fault.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Julio Faracco 2018-11-07 18:57:02 -02:00 committed by John Ferlan
parent 8f0f8425d7
commit 879fde3272
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lxc/lxc_container.c
View File

@ -867,9 +867,13 @@ static int lxcContainerSetReadOnly(void)
} }
} }
if (mounts) if (!mounts) {
qsort(mounts, nmounts, sizeof(mounts[0]), ret = 0;
virStringSortRevCompare); goto cleanup;
}
qsort(mounts, nmounts, sizeof(mounts[0]),
virStringSortRevCompare);
for (i = 0; i < nmounts; i++) { for (i = 0; i < nmounts; i++) {
VIR_DEBUG("Bind readonly %s", mounts[i]); VIR_DEBUG("Bind readonly %s", mounts[i]);
@ -883,9 +887,7 @@ static int lxcContainerSetReadOnly(void)
ret = 0; ret = 0;
cleanup: cleanup:
for (i = 0; i < nmounts; i++) virStringListFreeCount(mounts, nmounts);
VIR_FREE(mounts[i]);
VIR_FREE(mounts);
endmntent(procmnt); endmntent(procmnt);
return ret; return ret;