From 8aced2ea32cb74fdb1f038161e6842aa80d6ae51 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 22 Aug 2018 13:09:50 +0200 Subject: [PATCH] qemu: hotplug: Don't leak 'nodename' in qemuDomainChangeMediaBlockdev qemuDomainDiskGetBackendAlias allocates a copy of the nodename string so we need to free it at the end. Found by Coverity. Signed-off-by: Peter Krempa Reviewed-by: John Ferlan --- src/qemu/qemu_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 1a9a9e1a32..0b84a503bb 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -700,6 +700,7 @@ qemuDomainChangeMediaBlockdev(virQEMUDriverPtr driver, cleanup: qemuHotplugDiskSourceDataFree(newbackend); qemuHotplugDiskSourceDataFree(oldbackend); + VIR_FREE(nodename); /* caller handles correct exchange of sources */ disk->src = oldsrc; return ret;