From 8f1bfd8fdb89fd10e2d4039ff5f56f2c931f0f91 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 12 Nov 2018 16:00:03 +0100 Subject: [PATCH] util: error: Add error message versions with info for some error codes Few error codes were missing the version of the message with additional info. In case of the modified messages it's not very likely they'll ever report any additional data, but for the sake of consistency we should provide them. Signed-off-by: Peter Krempa Reviewed-by: Erik Skultety --- src/util/virerror.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index ce0679b23e..a32a1fbd41 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -924,7 +924,10 @@ virErrorMsg(virErrorNumber error, const char *info) errmsg = _("internal error"); break; case VIR_ERR_NO_MEMORY: - errmsg = _("out of memory"); + if (info == NULL) + errmsg = _("out of memory"); + else + errmsg = _("out of memory: %s"); break; case VIR_ERR_NO_SUPPORT: if (info == NULL) @@ -1017,7 +1020,10 @@ virErrorMsg(virErrorNumber error, const char *info) errmsg = _("unknown OS type %s"); break; case VIR_ERR_NO_KERNEL: - errmsg = _("missing kernel information"); + if (info == NULL) + errmsg = _("missing kernel information"); + else + errmsg = _("missing kernel information: %s"); break; case VIR_ERR_NO_ROOT: if (info == NULL) @@ -1470,7 +1476,10 @@ virErrorMsg(virErrorNumber error, const char *info) errmsg = _("XML document failed to validate against schema: %s"); break; case VIR_ERR_MIGRATE_FINISH_OK: - errmsg = _("migration successfully aborted"); + if (info == NULL) + errmsg = _("migration successfully aborted"); + else + errmsg = _("migration successfully aborted: %s"); break; case VIR_ERR_NO_SERVER: if (info == NULL)