openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove overengineered loop 

Do not loop over enum with one value.
This commit is contained in:
Ján Tomko 2015-04-10 14:28:41 +02:00
parent fbcf7da95b
commit 9146fd7aa9
1 changed files with 10 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/storage/storage_backend.c
View File

@ -818,7 +818,6 @@ virStorageBackendCreateQemuImgOpts(char **opts,
struct _virStorageBackendQemuImgInfo info)
{
virBuffer buf = VIR_BUFFER_INITIALIZER;
size_t i;
if (info.backingPath)
virBufferAsprintf(&buf, "backing_fmt=%s,",
@ -832,28 +831,18 @@ virStorageBackendCreateQemuImgOpts(char **opts,
if (info.compat)
virBufferAsprintf(&buf, "compat=%s,", info.compat);
if (info.features && info.format == VIR_STORAGE_FILE_QCOW2) {
for (i = 0; i < VIR_STORAGE_FILE_FEATURE_LAST; i++) {
if (virBitmapIsBitSet(info.features, i)) {
switch ((virStorageFileFeature) i) {
case VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS:
if (STREQ_NULLABLE(info.compat, "0.10")) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Feature %s not supported with compat"
" level %s"),
virStorageFileFeatureTypeToString(i),
info.compat);
goto error;
}
break;
/* coverity[dead_error_begin] */
case VIR_STORAGE_FILE_FEATURE_LAST:
;
}
virBufferAsprintf(&buf, "%s,",
virStorageFileFeatureTypeToString(i));
if (info.features && info.format == VIR_STORAGE_FILE_QCOW2) {
if (virBitmapIsBitSet(info.features,
VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS)) {
if (STREQ_NULLABLE(info.compat, "0.10")) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("lazy_refcounts not supported with compat"
" level %s"),
info.compat);
goto error;
}
virBufferAddLit(&buf, "lazy_refcounts,");
}
}