From 96d01ce9690d1f6b79b7ae76552c6e440d7f4eaf Mon Sep 17 00:00:00 2001 From: Lin Ma Date: Tue, 10 Nov 2020 17:51:02 +0800 Subject: [PATCH] virsh: Add signal name completion to send-process-signal command Signed-off-by: Lin Ma Signed-off-by: Michal Privoznik Reviewed-by: Michal Privoznik --- tools/virsh-completer-domain.c | 21 +++++++++++++++++++++ tools/virsh-completer-domain.h | 4 ++++ tools/virsh-domain.c | 1 + 3 files changed, 26 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 4612a9e51d..1d3499d5ab 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -715,3 +715,24 @@ virshDomainConsoleCompleter(vshControl *ctl, return g_steal_pointer(&tmp); } + + +char ** +virshDomainSignalCompleter(vshControl *ctl G_GNUC_UNUSED, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + VIR_AUTOSTRINGLIST tmp = NULL; + size_t i = 0; + + virCheckFlags(0, NULL); + + tmp = g_new0(char *, VIR_DOMAIN_PROCESS_SIGNAL_LAST + 1); + + for (i = 0; i < VIR_DOMAIN_PROCESS_SIGNAL_LAST; i++) { + const char *name = virDomainProcessSignalTypeToString(i); + tmp[i] = g_strdup(name); + } + + return g_steal_pointer(&tmp); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index 02fea2fe94..cdec66f23e 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -98,3 +98,7 @@ char ** virshDomainVcpulistViaAgentCompleter(vshControl *ctl, char ** virshDomainConsoleCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** virshDomainSignalCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 472b510a6b..1406bb4583 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8905,6 +8905,7 @@ static const vshCmdOptDef opts_send_process_signal[] = { {.name = "signame", .type = VSH_OT_DATA, .flags = VSH_OFLAG_REQ, + .completer = virshDomainSignalCompleter, .help = N_("the signal number or name") }, {.name = NULL}