From 97914d039d82f1c73de0786fa25bff34d1899e3f Mon Sep 17 00:00:00 2001 From: Matt Coleman Date: Thu, 5 Nov 2020 22:32:45 -0500 Subject: [PATCH] domain_conf: make virDomainDiskSourceFormatNetwork() void This function always returns zero, so it might as well be void. Signed-off-by: Matt Coleman Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 32fa01f2c4..9b3e2a5bcb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -25317,7 +25317,7 @@ virDomainDiskSourceFormatNetworkCookies(virBufferPtr buf, } -static int +static void virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf, virBufferPtr childBuf, virStorageSourcePtr src, @@ -25375,8 +25375,6 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf, if (src->timeout) virBufferAsprintf(childBuf, "\n", src->timeout); - - return 0; } @@ -25488,9 +25486,7 @@ virDomainDiskSourceFormat(virBufferPtr buf, break; case VIR_STORAGE_TYPE_NETWORK: - if (virDomainDiskSourceFormatNetwork(&attrBuf, &childBuf, - src, flags) < 0) - return -1; + virDomainDiskSourceFormatNetwork(&attrBuf, &childBuf, src, flags); break; case VIR_STORAGE_TYPE_VOLUME: