openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

conf: backup: Don't explicitly forbid backup of read-only disk 

Users may want to use this to create a full backup or even incremental
if the checkpoints are pre-existing. We still will not allow to create a
checkpoint on a read-only disk as that makes no sense.

https://bugzilla.redhat.com/show_bug.cgi?id=1840053

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Peter Krempa 2020-06-25 12:49:45 +02:00
parent ab7b3167b3
commit 981222b682
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/conf/backup_conf.c
View File

@ -411,13 +411,6 @@ virDomainBackupDefAssignStore(virDomainBackupDiskDefPtr disk,
_("disk '%s' has no media"), disk->name); _("disk '%s' has no media"), disk->name);
return -1; return -1;
} }
} else if (src->readonly) {
if (disk->store) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("backup of readonly disk '%s' makes no sense"),
disk->name);
return -1;
}
} else if (!disk->store) { } else if (!disk->store) {
if (virStorageSourceGetActualType(src) == VIR_STORAGE_TYPE_FILE) { if (virStorageSourceGetActualType(src) == VIR_STORAGE_TYPE_FILE) {
if (!(disk->store = virStorageSourceNew())) if (!(disk->store = virStorageSourceNew()))