From 98780c6be69f290c2a4956dd7747d3000908c7cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Tue, 10 Feb 2015 03:36:47 +0100 Subject: [PATCH] libxl: disable VNC and SDL until explicitly enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When initializing a libxl_domain_build_info struct with libxl_domain_build_info_init(), VNC is enabled by default. As a result, VMs configured with no graphics still have VNC enabled. This behavior is a regression wrt to the legacy Xen driver. Signed-off-by: Marek Marczykowski-Górecki --- src/libxl/libxl_conf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 4489f84695..e092b11df5 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -745,6 +745,10 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, return -1; } + /* Disable VNC and SDL until explicitly enabled */ + libxl_defbool_set(&b_info->u.hvm.vnc.enable, 0); + libxl_defbool_set(&b_info->u.hvm.sdl.enable, 0); + /* * The following comment and calculation were taken directly from * libxenlight's internal function libxl_get_required_shadow_memory():