From 9f8778dfca0a92572d9c00b0ed73b65a18a556d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Wed, 13 Dec 2017 20:15:49 +0100 Subject: [PATCH] xenconfig: fix issue found by coverity in multiple IP support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit virStringSplit may return NULL, so we must handle that. Cc: John Ferlan Signed-off-by: Marek Marczykowski-Górecki --- src/xenconfig/xen_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index 9777d23475..ca3b4dee6a 100644 --- a/src/xenconfig/xen_common.c +++ b/src/xenconfig/xen_common.c @@ -968,6 +968,9 @@ xenParseVif(virConfPtr conf, virDomainDefPtr def, const char *vif_typename) char **ip_list = virStringSplit(ip, " ", 0); size_t i; + if (!ip_list) + goto cleanup; + for (i = 0; ip_list[i]; i++) { if (virDomainNetAppendIPAddress(net, ip_list[i], 0, 0) < 0) { virStringListFree(ip_list);