From a5217cd7c04497056f535dc6e6938fea0f6a5865 Mon Sep 17 00:00:00 2001
From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 24 Oct 2019 08:06:21 +0200
Subject: [PATCH] util: buffer: Simplify convoluted condition
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Spare a few more lines rather than having a condition with a nested
ternary.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 src/util/virbuffer.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index 04c8fd7291..a58481430a 100644
--- a/src/util/virbuffer.c
+++ b/src/util/virbuffer.c
@@ -64,11 +64,19 @@ virBufferAdjustIndent(virBufferPtr buf, int indent)
 {
     if (!buf || buf->error)
         return;
-    if (indent > 0 ? INT_MAX - indent < buf->indent
-        : buf->indent < -indent) {
-        virBufferSetError(buf, -1);
-        return;
+
+    if (indent > 0) {
+        if (INT_MAX - indent < buf->indent) {
+            virBufferSetError(buf, -1);
+            return;
+        }
+    } else {
+        if (buf->indent < -indent) {
+            virBufferSetError(buf, -1);
+            return;
+        }
     }
+
     buf->indent += indent;
 }