From ab85f52c381ed31867687ffbbdd4a7cfdfbe1169 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 13 Oct 2021 17:06:15 +0200 Subject: [PATCH] qemuMonitorJSONAddDeviceProps: Simplify construction of the command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use 'qemuMonitorJSONMakeCommandInternal' instead of 'qemuMonitorJSONMakeCommand' + 'virJSONValueObjectAppend'. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_monitor_json.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index a3bdfaaf0d..2cfae2276d 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -4154,11 +4154,8 @@ qemuMonitorJSONAddDeviceProps(qemuMonitor *mon, g_autoptr(virJSONValue) cmd = NULL; g_autoptr(virJSONValue) reply = NULL; - if (!(cmd = qemuMonitorJSONMakeCommand("device_add", NULL))) - return -1; - - if (virJSONValueObjectAppend(cmd, "arguments", props) < 0) - return -1; + if (!(cmd = qemuMonitorJSONMakeCommandInternal("device_add", props))) + return -1; if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) return -1;