From b80fff1444278efb79d52e2ff6b16770db060395 Mon Sep 17 00:00:00 2001 From: Hongwei Bi Date: Wed, 25 Sep 2013 22:54:24 +0800 Subject: [PATCH] virsh-domain: Add a missing check and fix leak in cmdScreenshot Signed-off-by: Eric Blake --- tools/virsh-domain.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 856e8885b4..be7fcc8b35 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4610,7 +4610,8 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd) if (!(dom = vshCommandOptDomain(ctl, cmd, &name))) return false; - st = virStreamNew(ctl->conn, 0); + if (!(st = virStreamNew(ctl->conn, 0))) + goto cleanup; mime = virDomainScreenshot(dom, st, screen, flags); if (!mime) { @@ -4619,8 +4620,8 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd) } if (!file) { - if (!(file=vshGenFileName(ctl, dom, mime))) - return false; + if (!(file = vshGenFileName(ctl, dom, mime))) + goto cleanup; generated = true; }