openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

esx_vi_generator: Simplify get_occurrence_comment 

Reduce the number of if-statements and use a single return.
Utilise a dictionary to map between occurrences and values.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
This commit is contained in:
Radostin Stoyanov 2018-03-20 06:48:50 +00:00 committed by Daniel P. Berrangé
parent 25409b2dd3
commit b89111afed
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/esx/esx_vi_generator.py
View File

@ -75,16 +75,17 @@ class Member:
def get_occurrence_comment(self):
if self.occurrence == OCCURRENCE__REQUIRED_ITEM:
return "/* required */"
elif self.occurrence == OCCURRENCE__REQUIRED_LIST:
return "/* required, list */"
elif self.occurrence == OCCURRENCE__OPTIONAL_ITEM:
return "/* optional */"
elif self.occurrence == OCCURRENCE__OPTIONAL_LIST:
return "/* optional, list */"
occurrence_map = {
OCCURRENCE__REQUIRED_ITEM: "/* required */",
OCCURRENCE__REQUIRED_LIST: "/* required, list */",
OCCURRENCE__OPTIONAL_ITEM: "/* optional */",
OCCURRENCE__OPTIONAL_LIST: "/* optional, list */"
}
try:
return occurrence_map[self.occurrence]
except KeyError:
raise ValueError("unknown occurrence value '%s'" % self.occurrence)
raise ValueError("unknown occurrence value '%s'" % self.occurrence)