openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

examples: domtop: Avoid leaking memory 

Use the virTypedParamsFree unconditionally as it handles NULL well and
has the benefit of freeing a typed parameter array even if it wasn't yet
assigned, but only allocated.
This commit is contained in:
Peter Krempa 2014-07-21 09:53:17 +02:00
parent abab113bd2
commit ba2b4da02d
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
examples/domtop/domtop.c
View File

@ -334,12 +334,8 @@ do_top(virConnectPtr conn,
ret = 0;
cleanup:
if (max_id > 0) {
if (now_nparams > 0)
virTypedParamsFree(now_params, now_nparams * max_id);
if (then_nparams > 0)
virTypedParamsFree(then_params, then_nparams * max_id);
}
virTypedParamsFree(now_params, now_nparams * max_id);
virTypedParamsFree(then_params, then_nparams * max_id);
if (dom)
virDomainFree(dom);
return ret;