openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Don't validate disk type in virsh attach-disk 

Let the underlying driver tell us what it supports. At the moment
we are at least erroneously denying floppy eject/insert.
This commit is contained in:
Cole Robinson 2009-05-19 13:04:46 +00:00
parent 5b13f4375d
commit bb175dfc53
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
Tue May 19 09:04:05 EDT 2009 Cole Robinson <crobinso@redhat.com>
* src/virsh.c: Don't validate disk type in virsh attach-disk
Tue May 19 09:00:43 EDT 2009 Cole Robinson <crobinso@redhat.com> Tue May 19 09:00:43 EDT 2009 Cole Robinson <crobinso@redhat.com>
* python/libvir.py: Don't overwrite legitimate python import error. * python/libvir.py: Don't overwrite legitimate python import error.

7
src/virsh.c
View File

@ -5509,13 +5509,6 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd)
type = vshCommandOptString(cmd, "type", NULL); type = vshCommandOptString(cmd, "type", NULL);
mode = vshCommandOptString(cmd, "mode", NULL); mode = vshCommandOptString(cmd, "mode", NULL);
if (type) {
if (STRNEQ(type, "cdrom") && STRNEQ(type, "disk")) {
vshError(ctl, FALSE, _("No support %s in command 'attach-disk'"), type);
goto cleanup;
}
}
if (driver) { if (driver) {
if (STREQ(driver, "file") || STREQ(driver, "tap")) { if (STREQ(driver, "file") || STREQ(driver, "tap")) {
isFile = 1; isFile = 1;