openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

vircgroup: no need to use PID in virCgroupEnableMissingControllers 

This function is relevant only with cgroups v1 where it creates
hierarchy for controllers that are not managed by systemd. PID is used
to detect a placement of current process but in this situation we are
building the hierarchy for already known placement.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Pavel Hrdina 2020-10-15 16:59:03 +02:00
parent 13958a8c5b
commit c16da281e4
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/util/vircgroup.c
View File

@ -1112,14 +1112,13 @@ virCgroupNewDetectMachine(const char *name,
static int
virCgroupEnableMissingControllers(char *path,
pid_t pidleader,
int controllers,
virCgroupPtr *group)
{
g_autoptr(virCgroup) parent = NULL;
char *offset = path;
if (virCgroupNew(pidleader,
if (virCgroupNew(-1,
"/",
controllers,
&parent) < 0)
@ -1213,10 +1212,8 @@ virCgroupNewMachineSystemd(const char *name,
return -2;
}
if (virCgroupEnableMissingControllers(path, pidleader,
controllers, &newGroup) < 0) {
if (virCgroupEnableMissingControllers(path, controllers, &newGroup) < 0)
return -1;
}
if (virCgroupAddProcess(newGroup, pidleader) < 0) {
virErrorPtr saved;