From c5972df7d5a397e3e39a3b619db9b2a695e40373 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Fri, 5 Feb 2016 17:46:07 +0100 Subject: [PATCH] vboxDumpDisplay: remove suspicious strlen The return type of strlen is 'size_t', which is unsigned and therefore never less than zero. Use STREQ to make the check obvious. --- src/vbox/vbox_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 72938e9f62..38813963dc 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -3336,7 +3336,7 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine) VBOX_UTF16_TO_UTF8(valueDisplayUtf16, &valueDisplayUtf8); VBOX_UTF16_FREE(valueDisplayUtf16); - if (strlen(valueDisplayUtf8) <= 0) + if (STREQ(valueDisplayUtf8, "")) VBOX_UTF8_FREE(valueDisplayUtf8); }