From c679e8a41d01fd972cd4806da559bf8a0df34490 Mon Sep 17 00:00:00 2001 From: Yi Wang Date: Wed, 24 May 2017 22:20:16 -0400 Subject: [PATCH] qemu: Fix memory leak in qemuDomainUpdateMemoryDeviceInfo The @meminfo allocated in qemuMonitorGetMemoryDeviceInfo() may be lost when qemuDomainObjExitMonitor() failed. Signed-off-by: Yi Wang Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index c8dc748139..d9f336b98a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5767,8 +5767,10 @@ qemuDomainUpdateMemoryDeviceInfo(virQEMUDriverPtr driver, rc = qemuMonitorGetMemoryDeviceInfo(priv->mon, &meminfo); - if (qemuDomainObjExitMonitor(driver, vm) < 0) + if (qemuDomainObjExitMonitor(driver, vm) < 0) { + virHashFree(meminfo); return -1; + } /* if qemu doesn't support the info request, just carry on */ if (rc == -2)