diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7427efbd31..6a772c6666 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20082,6 +20082,12 @@ virDomainDiskBackingStoreFormat(virBufferPtr buf, } +#define FORMAT_IOTUNE(val) \ + if (def->blkdeviotune.val) { \ + virBufferAsprintf(buf, "<" #val ">%llu\n", \ + def->blkdeviotune.val); \ + } + static int virDomainDiskDefFormat(virBufferPtr buf, virDomainDiskDefPtr def, @@ -20269,66 +20275,20 @@ virDomainDiskDefFormat(virBufferPtr buf, def->blkdeviotune.size_iops_sec) { virBufferAddLit(buf, "\n"); virBufferAdjustIndent(buf, 2); - if (def->blkdeviotune.total_bytes_sec) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.total_bytes_sec); - } - if (def->blkdeviotune.read_bytes_sec) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.read_bytes_sec); + FORMAT_IOTUNE(total_bytes_sec); + FORMAT_IOTUNE(read_bytes_sec); + FORMAT_IOTUNE(write_bytes_sec); + FORMAT_IOTUNE(total_iops_sec); + FORMAT_IOTUNE(read_iops_sec); + FORMAT_IOTUNE(write_iops_sec); - } - - if (def->blkdeviotune.write_bytes_sec) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.write_bytes_sec); - } - - if (def->blkdeviotune.total_iops_sec) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.total_iops_sec); - } - - if (def->blkdeviotune.read_iops_sec) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.read_iops_sec); - } - - if (def->blkdeviotune.write_iops_sec) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.write_iops_sec); - } - - if (def->blkdeviotune.total_bytes_sec_max) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.total_bytes_sec_max); - } - - if (def->blkdeviotune.read_bytes_sec_max) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.read_bytes_sec_max); - } - - if (def->blkdeviotune.write_bytes_sec_max) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.write_bytes_sec_max); - } - - if (def->blkdeviotune.total_iops_sec_max) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.total_iops_sec_max); - } - - if (def->blkdeviotune.read_iops_sec_max) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.read_iops_sec_max); - } - - if (def->blkdeviotune.write_iops_sec_max) { - virBufferAsprintf(buf, "%llu\n", - def->blkdeviotune.write_iops_sec_max); - } + FORMAT_IOTUNE(total_bytes_sec_max); + FORMAT_IOTUNE(read_bytes_sec_max); + FORMAT_IOTUNE(write_bytes_sec_max); + FORMAT_IOTUNE(total_iops_sec_max); + FORMAT_IOTUNE(read_iops_sec_max); + FORMAT_IOTUNE(write_iops_sec_max); if (def->blkdeviotune.size_iops_sec) { virBufferAsprintf(buf, "%llu\n", @@ -20360,6 +20320,7 @@ virDomainDiskDefFormat(virBufferPtr buf, virBufferAddLit(buf, "\n"); return 0; } +#undef FORMAT_IOTUNE static int