From ce6de782e9aea06489c31ebbe62e8d1659060c86 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 30 Jan 2013 09:54:41 -0500 Subject: [PATCH] uml: Resolve leak if need to requery in umlIdentifyOneChrPTY() Coverity noted that in the retry logic loop if res had been set, then it could be leaked so add a VIR_FREE(res) prior to retry. --- src/uml/uml_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index f2cdc8d8e0..3f245b6bdf 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -1,7 +1,7 @@ /* * uml_driver.c: core driver methods for managing UML guests * - * Copyright (C) 2006-2012 Red Hat, Inc. + * Copyright (C) 2006-2013 Red Hat, Inc. * Copyright (C) 2006-2008 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -261,6 +261,7 @@ requery: /* XXX should do this in a better non-blocking way somehow ...perhaps register a timer */ if (retries++ < 50) { + VIR_FREE(res); usleep(1000*10); goto requery; }