From d41af4b4357d511e1782ee35f1c209087a78c06e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
Date: Fri, 29 Mar 2019 15:22:46 +0100
Subject: [PATCH] virsh-completer: use VIR_AUTOFREE for char* variables
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh-completer.c | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index f9231b3f88..108680b207 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -666,11 +666,11 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
     const char *suffix = NULL;
     const char *cellnum = NULL;
     bool cellno = vshCommandOptBool(cmd, "cellno");
-    char *path = NULL;
-    char *pagesize = NULL;
-    char *cap_xml = NULL;
+    VIR_AUTOFREE(char *) path = NULL;
+    VIR_AUTOFREE(char *) pagesize = NULL;
+    VIR_AUTOFREE(char *) cap_xml = NULL;
     char **ret = NULL;
-    char *unit = NULL;
+    VIR_AUTOFREE(char *) unit = NULL;
     VIR_AUTOSTRINGLIST tmp = NULL;
 
     virCheckFlags(0, NULL);
@@ -718,10 +718,6 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
     VIR_STEAL_PTR(ret, tmp);
 
  cleanup:
-    VIR_FREE(path);
-    VIR_FREE(pagesize);
-    VIR_FREE(cap_xml);
-    VIR_FREE(unit);
     return ret;
 
  error:
@@ -830,8 +826,8 @@ virshDomainInterfaceStateCompleter(vshControl *ctl,
     char macstr[VIR_MAC_STRING_BUFLEN] = "";
     int ninterfaces;
     VIR_AUTOFREE(xmlNodePtr *) interfaces = NULL;
-    char *xpath = NULL;
-    char *state = NULL;
+    VIR_AUTOFREE(char *) xpath = NULL;
+    VIR_AUTOFREE(char *) state = NULL;
     VIR_AUTOSTRINGLIST tmp = NULL;
 
     virCheckFlags(0, NULL);
@@ -877,8 +873,6 @@ virshDomainInterfaceStateCompleter(vshControl *ctl,
     VIR_STEAL_PTR(ret, tmp);
 
  cleanup:
-    VIR_FREE(state);
-    VIR_FREE(xpath);
     return ret;
 
  error:
@@ -926,7 +920,7 @@ virshCellnoCompleter(vshControl *ctl,
     VIR_AUTOFREE(xmlNodePtr *) cells = NULL;
     VIR_AUTOPTR(xmlDoc) doc = NULL;
     size_t i = 0;
-    char *cap_xml = NULL;
+    VIR_AUTOFREE(char *) cap_xml = NULL;
     char **ret = NULL;
     VIR_AUTOSTRINGLIST tmp = NULL;
 
@@ -956,7 +950,6 @@ virshCellnoCompleter(vshControl *ctl,
     VIR_STEAL_PTR(ret, tmp);
 
  cleanup:
-    VIR_FREE(cap_xml);
     return ret;
 
  error: