admin_server: Avoid accessing unallocated memory

In 68b726b93c we tried to fix a mem leak. However, it
wasn't done quite well. Problem is, virNetDaemonGetServers() may
fail in which case virObjectListFreeCount() would be called with
-1 objects to free. But the number of elements is taken in
unsigned rather than signed integer.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2016-03-25 10:18:00 +01:00
parent 3e5b35a538
commit d715bfac08
1 changed files with 2 additions and 1 deletions

View File

@ -54,7 +54,8 @@ adminConnectListServers(virNetDaemonPtr dmn,
srvs = NULL;
}
cleanup:
virObjectListFreeCount(srvs, ret);
if (ret > 0)
virObjectListFreeCount(srvs, ret);
return ret;
}