openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

util: Remove unused virExec wrapper 

v3:
    Remove obsolete comment

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2011-05-06 16:36:16 -04:00
parent 1ba75cf9aa
commit d886ed9597
4 changed files with 0 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cfg.mk
View File

@ -263,7 +263,6 @@ sc_prohibit_close:
$(_sc_search_regexp)
# Prefer virCommand for all child processes.
# XXX - eventually, we want to enhance this to also prohibit virExec.
sc_prohibit_fork_wrappers:
@prohibit='= *\<(fork|popen|system) *\(' \
halt='use virCommand for child processes' \

1
src/libvirt_private.syms
View File

@ -968,7 +968,6 @@ virEnumFromString;
virEnumToString;
virEventAddHandle;
virEventRemoveHandle;
virExec;
virExecWithHook;
virFileAbsPath;
virFileBuildPath;

35
src/util/util.c
View File

@ -752,26 +752,6 @@ virExecWithHook(const char *const*argv,
return -1;
}
/*
* See virExecWithHook for explanation of the arguments.
*
* Wrapper function for virExecWithHook, with a simpler set of parameters.
* Used to insulate the numerous callers from changes to virExecWithHook
* argument list.
*/
int
virExec(const char *const*argv,
const char *const*envp,
const fd_set *keepfd,
pid_t *retpid,
int infd, int *outfd, int *errfd,
int flags)
{
return virExecWithHook(argv, envp, keepfd, retpid,
infd, outfd, errfd,
flags, NULL, NULL, NULL);
}
/**
* @argv NULL terminated argv to run
* @status optional variable to return exit status in
@ -881,21 +861,6 @@ virRun(const char *const *argv ATTRIBUTE_UNUSED,
return -1;
}
int
virExec(const char *const*argv ATTRIBUTE_UNUSED,
const char *const*envp ATTRIBUTE_UNUSED,
const fd_set *keepfd ATTRIBUTE_UNUSED,
int *retpid ATTRIBUTE_UNUSED,
int infd ATTRIBUTE_UNUSED,
int *outfd ATTRIBUTE_UNUSED,
int *errfd ATTRIBUTE_UNUSED,
int flags ATTRIBUTE_UNUSED)
{
virUtilError(VIR_ERR_INTERNAL_ERROR,
"%s", _("virExec is not implemented for WIN32"));
return -1;
}
int
virExecWithHook(const char *const*argv ATTRIBUTE_UNUSED,
const char *const*envp ATTRIBUTE_UNUSED,

8
src/util/util.h
View File

@ -69,14 +69,6 @@ int virExecWithHook(const char *const*argv,
virExecHook hook,
void *data,
char *pidfile) ATTRIBUTE_RETURN_CHECK;
int virExec(const char *const*argv,
const char *const*envp,
const fd_set *keepfd,
pid_t *retpid,
int infd,
int *outfd,
int *errfd,
int flags) ATTRIBUTE_RETURN_CHECK;
int virRun(const char *const*argv, int *status) ATTRIBUTE_RETURN_CHECK;
int virPipeReadUntilEOF(int outfd, int errfd,
char **outbuf, char **errbuf);