openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

virnetserverservice: Resolve Coverity ARRAY_VS_SINGLETON 

Coverity complained about the following:

(3) Event ptr_arith:
   Performing pointer arithmetic on "cur_fd" in expression "cur_fd++".
130             return virNetServerServiceNewFD(*cur_fd++,

The complaint is that pointer arithmetic taking place instead of the
expected auto increment of the variable...  Adding some well placed
parentheses ensures our order of operation.
This commit is contained in:
John Ferlan 2014-08-28 09:03:47 -04:00
parent ef8da2ad11
commit e387f4c1f1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/rpc/virnetserverservice.c
View File

@ -125,9 +125,11 @@ virNetServerServiceNewFDOrUNIX(const char *path,
} else {
/*
* There's still enough file descriptors. In this case we'll
* use the current one and increment it afterwards.
* use the current one and increment it afterwards. Take care
* with order of operation for pointer arithmetic and auto
* increment on cur_fd - the parentheses are necessary.
*/
return virNetServerServiceNewFD(*cur_fd++,
return virNetServerServiceNewFD((*cur_fd)++,
auth,
#if WITH_GNUTLS
tls,