From f0c30589f29433ca32f087e0751e7265a8a63d0f Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Mon, 27 Jul 2020 09:09:44 +0200 Subject: [PATCH] meson: src: add check-symfile test Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa Reviewed-by: Neal Gompa --- src/Makefile.am | 13 +------------ src/meson.build | 12 ++++++++++++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 20e89cff1a..4746e06bdf 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -48,17 +48,6 @@ include secret/Makefile.inc.am include storage/Makefile.inc.am -BUILT_SOURCES += $(nodist_conf_DATA) - -# .libs/libvirt.so is built by libtool as a side-effect of the Makefile -# rule for libvirt.la. However, checking symbols relies on Linux ELF layout -if WITH_LINUX -check-symfile: libvirt.syms libvirt.la - $(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-symfile.py \ - libvirt.syms .libs/libvirt.so -else ! WITH_LINUX -check-symfile: -endif ! WITH_LINUX check-symsorting: $(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/check-symsorting.py \ $(srcdir) $(SYM_FILES) @@ -150,7 +139,7 @@ check-aclperms: $(srcdir)/access/viraccessperm.h \ $(srcdir)/access/viraccessperm.c -check-local: check-protocol check-symfile check-symsorting \ +check-local: check-protocol check-symsorting \ check-drivername check-driverimpls check-aclrules \ check-aclperms check-admin .PHONY: check-protocol $(PROTOCOL_STRUCTS:structs=struct) diff --git a/src/meson.build b/src/meson.build index 93bca01dda..d5820bfb53 100644 --- a/src/meson.build +++ b/src/meson.build @@ -819,3 +819,15 @@ meson.add_install_script( meson_python_prog.path(), python3_prog.path(), meson_install_dirs_prog.path(), virt_install_dirs, ) + + +# Check driver files + +if host_machine.system() == 'linux' + test( + 'check-symfile', + python3_prog, + args: [ check_symfile_prog.path(), libvirt_syms, libvirt_lib ], + env: runutf8, + ) +endif