From f15f155403e36a66e3568676105fdca725ad2c52 Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Thu, 11 May 2017 17:16:13 +0200 Subject: [PATCH] util: introduce virStringMatch Simply tries to match the provided regex on a string and returns the result. Useful if caller don't care about the matched substring and want to just test if some pattern patches a string. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/virstring.c | 32 +++++++++++++++++++++++++++ src/util/virstring.h | 3 +++ tests/virstringtest.c | 47 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 83 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index afb9100c50..d32c6e7549 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2621,6 +2621,7 @@ virStringListHasString; virStringListJoin; virStringListLength; virStringListRemove; +virStringMatch; virStringReplace; virStringSearch; virStringSortCompare; diff --git a/src/util/virstring.c b/src/util/virstring.c index 335e773d78..089b53946a 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -978,6 +978,38 @@ virStringSearch(const char *str, return ret; } +/** + * virStringMatch: + * @str: string to match + * @regexp: POSIX Extended regular expression pattern used for matching + * + * Performs a POSIX extended regex match against a string. + * Returns true on match, false on error or no match. + */ +bool +virStringMatch(const char *str, + const char *regexp) +{ + regex_t re; + int rv; + + VIR_DEBUG("match '%s' for '%s'", str, regexp); + + if ((rv = regcomp(&re, regexp, REG_EXTENDED | REG_NOSUB)) != 0) { + char error[100]; + regerror(rv, &re, error, sizeof(error)); + VIR_WARN("error while compiling regular expression '%s': %s", + regexp, error); + return false; + } + + rv = regexec(&re, str, 0, NULL, 0); + + regfree(&re); + + return rv == 0; +} + /** * virStringReplace: * @haystack: the source string to process diff --git a/src/util/virstring.h b/src/util/virstring.h index c545ca3f0d..0038a405b1 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -274,6 +274,9 @@ ssize_t virStringSearch(const char *str, char ***matches) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4); +bool virStringMatch(const char *str, + const char *regexp); + char *virStringReplace(const char *haystack, const char *oldneedle, const char *newneedle) diff --git a/tests/virstringtest.c b/tests/virstringtest.c index 96bc79f832..97c6e76dcb 100644 --- a/tests/virstringtest.c +++ b/tests/virstringtest.c @@ -480,6 +480,38 @@ testStringSearch(const void *opaque) } +struct stringMatchData { + const char *str; + const char *regexp; + bool expectMatch; +}; + +static int +testStringMatch(const void *opaque) +{ + const struct stringMatchData *data = opaque; + bool match; + + match = virStringMatch(data->str, data->regexp); + + if (data->expectMatch) { + if (!match) { + fprintf(stderr, "expected match for '%s' on '%s' but got no match\n", + data->regexp, data->str); + return -1; + } + } else { + if (match) { + fprintf(stderr, "expected no match for '%s' on '%s' but got match\n", + data->regexp, data->str); + return -1; + } + } + + return 0; +} + + struct stringReplaceData { const char *haystack; const char *oldneedle; @@ -803,6 +835,21 @@ mymain(void) const char *matches3[] = { "foo", "bar" }; TEST_SEARCH("1foo2bar3eek", "([a-z]+)", 2, 2, matches3, false); +#define TEST_MATCH(s, r, m) \ + do { \ + struct stringMatchData data = { \ + .str = s, \ + .regexp = r, \ + .expectMatch = m, \ + }; \ + if (virTestRun("virStringMatch " s, testStringMatch, &data) < 0) \ + ret = -1; \ + } while (0) + + TEST_MATCH("foo", "foo", true); + TEST_MATCH("foobar", "f[o]+", true); + TEST_MATCH("foobar", "^f[o]+$", false); + #define TEST_REPLACE(h, o, n, r) \ do { \ struct stringReplaceData data = { \