openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

qemu: avoid fd leak on core dump failure 

* src/qemu/qemu_driver.c (doCoreDump): Guarantee fd is closed.
This commit is contained in:
Eric Blake 2011-07-11 12:07:11 -06:00
parent 2ceb35e1cd
commit f532bfa297
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/qemu/qemu_driver.c
View File

@ -2525,10 +2525,11 @@ cleanup:
return ret;
}
static int doCoreDump(struct qemud_driver *driver,
virDomainObjPtr vm,
const char *path,
enum qemud_save_formats compress)
static int
doCoreDump(struct qemud_driver *driver,
virDomainObjPtr vm,
const char *path,
enum qemud_save_formats compress)
{
int fd = -1;
int ret = -1;
@ -2554,6 +2555,7 @@ static int doCoreDump(struct qemud_driver *driver,
ret = 0;
cleanup:
VIR_FORCE_CLOSE(fd);
if (ret != 0)
unlink(path);
return ret;