From f5eae5708623401f50a07729283624423894ed68 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Wed, 2 Oct 2013 11:10:45 +0100 Subject: [PATCH] Don't set netdev offline in container cleanup During container cleanup there is a race where the kernel may have destroyed the veth device before we try to set it offline. This causes log error messages. Given that we're about to delete the device entirely, setting it offline is pointless. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_process.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index f92c613293..a78784e5c1 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -193,7 +193,6 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver, virDomainNetDefPtr iface = vm->def->nets[i]; vport = virDomainNetGetActualVirtPortProfile(iface); if (iface->ifname) { - ignore_value(virNetDevSetOnline(iface->ifname, false)); if (vport && vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH) ignore_value(virNetDevOpenvswitchRemovePort(