From fa18da2d8168d9438a0b2901e023386170f326fb Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 9 Jul 2018 12:59:20 +0200 Subject: [PATCH] storage_util: Prefer generic FICLONE over btrfs/xfs defines After my change to the original patch that resulted in commit 8ed874b39b3 it was brought to my attention that all three defines are the same: FICLONE = BTRFS_IOC_CLONE = XFS_IOC_CLONE (as documented in ioctl_ficlone(2)). Therefore we should prefer generic FICLONE over 'specific' defines for btrfs/xfs. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani --- src/storage/storage_util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index da99043e0a..715d5c2f88 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -46,14 +46,14 @@ # include #endif -#if HAVE_LINUX_BTRFS_H +#ifdef FICLONE +# define REFLINK_IOC_CLONE FICLONE +#elif HAVE_LINUX_BTRFS_H # include # define REFLINK_IOC_CLONE BTRFS_IOC_CLONE #elif HAVE_XFS_XFS_H # include # define REFLINK_IOC_CLONE XFS_IOC_CLONE -#elif defined(FICLONE) -# define REFLINK_IOC_CLONE FICLONE #endif #include "datatypes.h"