From fc81be4bfa499ffd52c54d0f22913b3efeaa7db5 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 8 Mar 2022 18:08:54 +0100 Subject: [PATCH] qemuDomainSnapshotForEachQcow2Raw: Act only on internal snapshots MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Similarly to the external snapshot code the internal inactive snapshot creation helper should act only when an internal snapshot of the disk is required. For now the callers ensure that it's either _INTERNAL or _NO when control reaches this function. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 936a0c8a35..f61509d00b 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6886,7 +6886,7 @@ qemuDomainSnapshotForEachQcow2Raw(virQEMUDriver *driver, /* FIXME: we also need to handle LVM here */ if (def->disks[i]->device != VIR_DOMAIN_DISK_DEVICE_DISK || - snapdef->disks[i].snapshot == VIR_DOMAIN_SNAPSHOT_LOCATION_NO) + snapdef->disks[i].snapshot != VIR_DOMAIN_SNAPSHOT_LOCATION_INTERNAL) continue; if (!virStorageSourceIsLocalStorage(def->disks[i]->src)) {