openkylin
/
libvirt
mirror of https://gitee.com/openkylin/libvirt.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

secretxml2xmltest: refactor testCompareXMLToXMLFiles 

Use g_auto where possible and remove the pointless label.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Ján Tomko 2021-09-04 20:34:55 +02:00
parent 709ef46b2d
commit ff6e806be5
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/secretxml2xmltest.c
View File

@ -10,25 +10,19 @@
static int
testCompareXMLToXMLFiles(const char *inxml, const char *outxml)
{
char *actual = NULL;
int ret = -1;
virSecretDef *secret = NULL;
g_autofree char *actual = NULL;
g_autoptr(virSecretDef) secret = NULL;
if (!(secret = virSecretDefParseFile(inxml)))
goto fail;
return -1;
if (!(actual = virSecretDefFormat(secret)))
goto fail;
return -1;
if (virTestCompareToFile(actual, outxml) < 0)
goto fail;
return -1;
ret = 0;
fail:
VIR_FREE(actual);
virSecretDefFree(secret);
return ret;
return 0;
}
struct testInfo {