6049594045
avoid using STREQLEN with a literal; use STRPREFIX instead
...
Likewise for STRNEQLEN -> !STRPREFIX.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate):
* src/qemu_conf.c (qemudNetworkIfaceConnect):
(qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/remote_internal.c (call):
* src/stats_linux.c (xenLinuxDomainDeviceID):
* src/xend_internal.c (xend_parse_sexp_desc):
(xend_get, sexpr_to_xend_topology):
* src/xm_internal.c (xenXMConfigCacheRefresh)
(xenXMDomainFormatXML):
2008-05-15 14:21:34 +00:00
abb9a583a0
* Makefile.maint (sc_prohibit_strcmp): Also prohibit strncmp.
2008-05-15 07:12:43 +00:00
b87f3000aa
Change libvirtd description from qemu only to various VM(i.e. Xen, LXC)
...
Fix typos and comments
2008-05-15 06:12:32 +00:00
13555de861
exempt gnulib/ from "make syntax-check" strcmp prohibition
...
* .x-sc_prohibit_strcmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp.
2008-05-14 21:18:27 +00:00
f7fe78dc82
Added listen_addr config param for daemon (Stefan de Konink)
2008-05-14 20:57:20 +00:00
1d73398e8f
Remove all use of strcmp, strncmp in favour of STREQ, STREQLEN, STRPREFIX
2008-05-14 19:51:24 +00:00
e830d52573
avoid "not a string literal..." warnings
...
* src/qemu_conf.c (qemudParseInterfaceXML): Add "%s".
(qemudBuildCommandLine, qemudGenerateXML): Likewise.
2008-05-13 09:15:11 +00:00
773d59e86d
Fix some stray leading spaces in Changelog entry for my last commit
2008-05-13 06:51:42 +00:00
94311de539
Enable libvirtd drivers to handle signals, in lxc, sigchld triggers vm cleanup
...
Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
* qemud/qemud.c: get siginfo with signals, distribute to drivers that
register a handler
* src/driver.h: add sighandler function to state driver table
* src/internal.h: define virStateSigDispatcher functions
* src/libvirt.c: add __virStateSigDispatcher function
* src/libvirt_sym.version: add __virStateSigDispatcher
* src/lxc_driver.c: add sig handler function, cleanup vm when sigchld
received from container process
* src/qemu_driver.c: NULL for sig handler (no handler) in state driver
* src/remote_internal.c: NULL for sig handler (no handler) in state driver
* src/storage_driver.c: NULL for sig handler (no handler) in state driver
2008-05-13 06:30:58 +00:00
098ba1a433
Add support for -drive QEMU syntax, and virtio bus / disk type
2008-05-09 16:41:19 +00:00
7967662a52
Add new files from gnulib.
...
* gnulib/lib/c-ctype.c: New file.
* gnulib/lib/c-ctype.h: Likewise.
* gnulib/tests/test-c-ctype.c: Likewise.
* gnulib/tests/test-vc-list-files-git.sh: Likewise.
* gnulib/tests/test-vc-list-files-cvs.sh: Likewise.
2008-05-09 14:03:15 +00:00
25534052bc
Use gnulib's c-ctype.h, not <ctype.h>.
...
# Convert uses of isspace to c_isspace, isdigit to c_isdigit, etc.
re=$(man isspace|grep is.....,.is|sed 's/ -.*//' \
|tr -s ', \n' \||sed 's/^|//;s/|$//')
git grep -l -E "$re"|grep -Ev 'Chan|gnulib' \
|xargs perl -pi -e 's/\b('"$re"')\b/c_$1/g'
# Remove all uses of to_uchar
git grep -l to_uchar|xargs perl -pi -e 's/to_uchar\((.*?)\)/$1/g'
* src/util.h (to_uchar): Remove definition.
(TOLOWER): Remove definition.
(__virMacAddrCompare): Use c_tolower, not TOLOWER.
Globally:
Where needed, change <ctype.h> to <c-ctype.h>.
Remove unnecessary inclusion of <ctype.h>.
Ensure the global changes are never needed again:
* Makefile.maint (sc_avoid_ctype_macros): Prohibit use of ctype
macros. Recommend c-ctype.h instead.
(sc_prohibit_c_ctype_without_use): New rule.
(sc_prohibit_ctype_h): New rule. Disallow use of <ctype.h>.
2008-05-09 13:50:14 +00:00
82892f131b
Prepare to use gnulib's c-type module.
...
* bootstrap: Move module list into separate variable w/less syntax.
(modules): Add c-ctype.
Update the following from gnulib:
* build-aux/useless-if-before-free:
* build-aux/vc-list-files:
* gnulib/lib/Makefile.am:
* gnulib/lib/getaddrinfo.h:
* gnulib/m4/gnulib-cache.m4:
* gnulib/m4/gnulib-comp.m4:
* gnulib/m4/inet_ntop.m4:
* gnulib/tests/Makefile.am:
* gnulib/tests/test-getaddrinfo.c:
2008-05-09 13:46:09 +00:00
5e1bd04692
autostart for running Xen domains
...
* src/xen_unified.c src/xend_internal.c src/xend_internal.h: patch
from Cole Robinson implementing autostart for running Xen domains
Daniel
2008-05-09 08:17:18 +00:00
eb046f9d59
sytnax-check: add a check for risky ctype macro use
...
* Makefile.maint (sc_risky_ctype_macros): New rule.
2008-05-09 08:11:13 +00:00
b8111adf35
avoid one more ctype vs. sign-extension problem
...
* src/util.c (TOLOWER): Also convert tolower argument.
2008-05-09 08:09:48 +00:00
712251009b
add "const" and "static" attributes to file-scoped globals
...
* src/storage_backend_fs.c (fileTypeInfo): Add "static" and two
"const" attributes.
(FileTypeInfo): Name the previously anonymous struct,
so the declaration of fileTypeInfo looks more conventional.
* src/xend_internal.c (sound_models): Mark as static, and
as an array of "const" entries.
These were relatively new additions to the list from here:
nm src/*.o|grep ' D '
2008-05-09 08:02:44 +00:00
6ca76333f3
*** empty log message ***
2008-05-09 07:16:30 +00:00
d9691ab277
Added some notes about libvirt string/memory/buffer functions
2008-05-08 14:49:53 +00:00
021bd31706
Added disk target bus type to Xen driver
2008-05-08 14:41:56 +00:00
979edb4a64
Update domain XML docs
2008-05-08 14:20:07 +00:00
7b21582e2d
Fix polkit docs
2008-05-08 11:52:21 +00:00
31b17e6d44
Disable sound functions when in proxy
2008-05-07 18:50:23 +00:00
da6316f20e
SetVcpus and DomainGetMaxVcpus for QEmu
...
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: another patch
from Cole Robinson adding SetVcpus and DomainGetMaxVcpus for QEmu
Daniel
2008-05-07 16:16:44 +00:00
0feb4c9552
More regression tests for sound support
...
* tests/qemuxml2argvdata/qemuxml2argv-sound.args
tests/qemuxml2argvdata/qemuxml2argv-sound.xml
tests/sexpr2xmldata/sexpr2xml-fv-sound-all.sexpr
tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml
tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr
tests/sexpr2xmldata/sexpr2xml-fv-sound.xml
tests/xmconfigdata/test-fullvirt-sound.cfg
tests/xmconfigdata/test-fullvirt-sound.xml
tests/xml2sexprdata/xml2sexpr-fv-sound.sexpr
tests/xml2sexprdata/xml2sexpr-fv-sound.xml: other regression
tests from previous commit
Daniel
2008-05-07 14:44:20 +00:00
70f446631f
Sound support for QEmu and Xen
...
* src/qemu_conf.c src/qemu_conf.h src/xend_internal.c
src/xend_internal.h src/xm_internal.c src/xml.c src/xml.h:
Patch from Cole Robinson adding sound support for QEmu and Xen
* tests/qemuxml2argvtest.c tests/sexpr2xmltest.c
tests/xmconfigtest.c tests/xml2sexprtest.c:
Associated regression tests
Daniel
2008-05-07 14:04:40 +00:00
2afd1db4a2
Fix build on F9 with missing stddefs.h include
2008-05-06 21:44:12 +00:00
924e953f47
* build-aux/vc-list-files: Add support for bzr.
...
Author: Soren Hansen <soren@ubuntu.com>
2008-05-06 21:23:20 +00:00
db3f10c807
Check in /usr/sbin for iptables too, for SUSE distros (Jim Fehlig)
2008-05-05 19:58:56 +00:00
b04e40d6a3
Remove bogus check for NULL in qparams breaking connections
2008-05-01 18:11:03 +00:00
3bc5510a63
Remove compat macros now present in onceonly.m4
2008-04-30 16:32:26 +00:00
07efaf941f
update from gnulib, again
...
* gnulib/m4/onceonly.m4: New file.
* gnulib/m4/printf.m4: New file.
* build-aux/useless-if-before-free: Update.
* build-aux/vc-list-files: Update.
* gnulib/lib/arpa_inet.in.h: Update.
* gnulib/lib/stdio-impl.h: Update.
* gnulib/m4/inet_ntop.m4: Update.
2008-04-30 16:11:08 +00:00
a9420c223e
Add compat for RHEL-5 autoconf
2008-04-30 15:54:40 +00:00
159cb2b97c
Added support for network interface model setting
2008-04-30 12:30:55 +00:00
303277a8dc
* gnulib/lib/stdio-impl.h: Add another new file from gnulib.
2008-04-29 21:43:50 +00:00
eb6c33cd97
* gnulib/tests/test-EOVERFLOW.c: Add another new file from gnulib.
2008-04-29 21:39:38 +00:00
ffdc37c2aa
Fix build errors.
...
* proxy/Makefile.am (libvirt_proxy_LDADD): Add ../gnulib/lib/libgnu.la.
* gnulib/lib/arpa_inet.in.h: Add new file from gnulib.
2008-04-29 21:23:34 +00:00
130426c659
update from gnulib
...
* gnulib/lib/inet_ntop.h: Remove file.
* gnulib/m4/onceonly_2_57.m4: Remove file.
* build-aux/useless-if-before-free: Update.
* build-aux/vc-list-files: Update.
* gnulib/lib/.cvsignore: Update.
* gnulib/lib/Makefile.am: Update.
* gnulib/lib/fseeko.c: Update.
* gnulib/lib/getaddrinfo.c: Update.
* gnulib/lib/getdelim.c: Update.
* gnulib/lib/inet_ntop.c: Update.
* gnulib/lib/inet_ntop.h: Update.
* gnulib/lib/poll.c: Update.
* gnulib/lib/snprintf.c: Update.
* gnulib/lib/stdlib.in.h: Update.
* gnulib/lib/string.in.h: Update.
* gnulib/lib/sys_socket.in.h: Update.
* gnulib/lib/sys_stat.in.h: Update.
* gnulib/lib/vasnprintf.c: Update.
* gnulib/lib/vasprintf.c: Update.
* gnulib/lib/wchar.in.h: Update.
* gnulib/m4/arpa_inet_h.m4: Update.
* gnulib/m4/extensions.m4: Update.
* gnulib/m4/gnulib-common.m4: Update.
* gnulib/m4/gnulib-comp.m4: Update.
* gnulib/m4/include_next.m4: Update.
* gnulib/m4/inet_ntop.m4: Update.
* gnulib/m4/netinet_in_h.m4: Update.
* gnulib/m4/onceonly_2_57.m4: Update.
* gnulib/m4/physmem.m4: Update.
* gnulib/m4/snprintf.m4: Update.
* gnulib/m4/stdint.m4: Update.
* gnulib/m4/stdio_h.m4: Update.
* gnulib/m4/stdlib_h.m4: Update.
* gnulib/m4/string_h.m4: Update.
* gnulib/m4/strndup.m4: Update.
* gnulib/m4/sys_select_h.m4: Update.
* gnulib/m4/sys_socket_h.m4: Update.
* gnulib/m4/sys_stat_h.m4: Update.
* gnulib/m4/vasnprintf.m4: Update.
* gnulib/tests/Makefile.am: Update.
* gnulib/tests/test-fseeko.c: Update.
* gnulib/tests/test-getaddrinfo.c: Update.
* gnulib/tests/test-getdelim.c: Update.
* gnulib/tests/test-getline.c: Update.
* gnulib/tests/test-lseek.c: Update.
* gnulib/tests/test-snprintf.c: Update.
* gnulib/tests/test-sys_stat.c: Update.
* gnulib/tests/test-vasnprintf.c: Update.
* gnulib/tests/test-vasprintf.c: Update.
2008-04-29 19:52:26 +00:00
0c37f59802
remove useless tests before xmlFree
...
* src/qemu_conf.c (qemudParseDiskXML, qemudParseInterfaceXML):
(qemudParseInputXML, qemudParseDhcpRangesXML):
* src/remote_internal.c (doRemoteOpen):
* src/storage_conf.c (virStoragePoolDefParseDoc):
* src/xm_internal.c (xenXMParseXMLDisk, xenXMParseXMLVif):
(xenXMParseXMLToConfig, xenXMAttachInterface):
* src/xml.c (virDomainParseXMLDiskDesc, virDomainParseXMLIfDesc):
(virDomainXMLDevID):
2008-04-29 19:43:57 +00:00
e9c7af6864
Tell gcov to look in .libs to find coverage data
2008-04-29 15:41:30 +00:00
12af012644
also check for useless test-before-xmlFree
...
* Makefile.cfg (useless_free_options): Add --name=xmlFree.
2008-04-29 15:06:14 +00:00
c3626941c7
tests: recognize more uses of strcmp.
...
* Makefile.maint (sc_prohibit_strcmp): Relax regexp.
2008-04-29 14:25:19 +00:00
b1f791adb0
Fix array out of bounds in capabilities code parsing
2008-04-29 14:13:54 +00:00
1968468ca4
Added network XML docs
2008-04-29 14:08:08 +00:00
7573ce3591
Remove bogus test code accidentally left in previous commit
2008-04-29 13:48:41 +00:00
724d0df7e5
Avoid "make syntax-check" failures.
...
* src/memory.c: Include "config.h".
Remove trailing blanks.
2008-04-29 13:37:20 +00:00
fe394e0baa
Avoid in-function #if directives.
...
* src/parthelper.c [!PED_PARTITION_PROTECTED]: Define to 0.
Remove in-function #ifdefs.
2008-04-29 13:20:46 +00:00
1e43bebf69
* src/parthelper.c: Don't fail if PED_PARTITION_PROTECTED
...
is not defined because of ancient libparted
(Soren Hansen).
2008-04-29 08:17:36 +00:00
4ffb0358de
Added safer lowlevel memory allocation APis. Converted hash.c and capabilities.c to use them
2008-04-28 21:44:54 +00:00
642b26fab2
Change virBuffer API to prevent common usage errors. Update all users of APIs
2008-04-28 15:14:59 +00:00
7301131e42
fix typo in bootstrap script
...
* bootstrap: Fix typo: s/gnulib/.gnulib/. Reported by
Daniel P. Berrange.
2008-04-28 14:12:45 +00:00
45008e03ec
Ignore bash bugs under valgrind
2008-04-28 13:36:48 +00:00
212472b813
avoid format-related warnings
...
* qemud/qemud.c (main): Fix a bogus format string reported as umarked.
* src/virsh.c (cmdVcpupin): Non-literal with no args.
2008-04-28 09:09:52 +00:00
8383c6640a
* docs/Makefile.am docs/et.png docs/libvirt.css docs/page.xsl
...
docs/*.html docs/html/*.html: removed footer, added sponsor logo
regenerated the html pages also fixed 'make distcheck' as
pointed by Jim.
Daniel
2008-04-28 08:29:35 +00:00
e6f1123819
Added full support for serial and parallel devices to Xen drivers
2008-04-26 14:22:02 +00:00
49956f0469
Implement serial & parallel device support for QEMU driver
2008-04-25 20:46:13 +00:00
d62a9f2390
Adapt layout to workaround IE6 bugs
2008-04-25 16:23:51 +00:00
384c5cff37
group ownership of /var/run/libvirt/
...
* qemud/qemud.c: applied patch from Anton Protopopov to change
group ownership of /var/run/libvirt/ to unix_sock_gid.
Daniel
2008-04-25 15:46:46 +00:00
225ba3f0af
avoid problems with sign-extended "char" operand to is* functions
...
* src/util.h (to_uchar): Define function.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate): Apply to_uchar to is* operand.
* src/qemu_driver.c (qemudExtractMonitorPath): Likewise.
* src/sexpr.c (_string2sexpr): Likewise.
* src/stats_linux.c (xenLinuxDomainDeviceID): Likewise.
* src/util.c (TOLOWER, __virMacAddrCompare, virParseMacAddr): Likewise.
* src/virsh.c (cmdVcpupin, vshCommandGetToken): Likewise.
2008-04-25 14:53:05 +00:00
9c38a1d0eb
Sponsor logo
...
* docs/page.xsl docs/redhat.gif docs/*.html: using the shadowman
logo to indicate Red Hat sponsoring, regenerated.
Daniel
2008-04-24 15:20:06 +00:00
3725f7af65
* AUTHORS: update, list people with commit access
...
Daniel
2008-04-24 12:35:28 +00:00
ca5600d29d
fix the search
...
* libvirt.css search.php: fix the search box and PHP output
Daniel
2008-04-24 09:44:00 +00:00
2ef22ecee3
* proxy/libvirt_proxy.c and docs/* typo fixing
...
Atsushi
2008-04-24 09:17:29 +00:00
bc4dacb286
Cosmetic doc improvements
...
* AUTHORS: indicate that the Logo is by Diana Fong
* docs/index.py: modify to also index subprojects pages
Daniel
2008-04-24 07:56:37 +00:00
c6b067d0c3
Fix generation of NEWS file
2008-04-23 19:39:59 +00:00
ea23f5ae45
Fix wiki link in API docs
2008-04-23 17:45:07 +00:00
9092c3d491
Split website out into one file per page. APply new layout and styling
2008-04-23 17:08:31 +00:00
95a7adf3e6
Enable 'make syntax-check's sc_changelog rule.
...
* Makefile.maint (sc_changelog): Adapt to work with legacy
ChangeLog entry header lines.
* Makefile.cfg (local-checks-to-skip): Remove sc_changelog.
2008-04-21 10:09:07 +00:00
b11f2be30e
Python header workaround
2008-04-18 18:31:32 +00:00
f41ba90c18
Work around Python.h name-space pollution.
...
* python/libvir.c (HAVE_PTHREAD_H): #undef.
Without this, we'd get a redefinition warning.
2008-04-18 18:07:40 +00:00
94353ef660
Re-factor and pretty print differences
2008-04-18 15:28:33 +00:00
484559148d
Test script helper for printing string differences
2008-04-18 15:05:29 +00:00
2d206f1d7a
avoid compile error when <pthread.h> is absent
...
* src/internal.h (HAVE_PTHREAD_H): Test with "#ifdef", not "#if".
2008-04-18 09:26:45 +00:00
8df91acf70
Fixes for MinGW.
...
* configure.in: Fix pkg-config detection of libxml2,
add -lgcrypt to gnutls lib.
* src/Makefile.am: If compiling --without-libvirtd then
don't compile any part of the storage driver.
* configure.in, src/hash.c, src/internal.h: Detect availability
of pthread library and compile out mutex code if not available.
* src/storage_driver.c, src/util.c: Ignore some missing
headers on MinGW.
2008-04-18 08:33:23 +00:00
49e6b7221c
Complete and cleanup virsh man page
...
* virsh.1 docs/virsh.pod: fix missing entries and small cleanups
in the man page, should fix #442429
Daniel
2008-04-15 15:20:43 +00:00
3e4ffa4ec0
Added lxc_container.c to POTFILES.in
2008-04-14 17:44:51 +00:00
ba5411995b
Remove unused uid field in virsh control structure.
...
* src/virsh.c: Remove unused uid field in virsh control structure.
2008-04-10 17:37:23 +00:00
fa8ddb744d
HACKING: New file: begin to describe contributor/coding guidelines
2008-04-10 16:56:44 +00:00
3b83d22e79
ensure that no C source file uses TABs for indentation
...
* Makefile.maint (sc_TAB_in_indentation): New rule.
2008-04-10 16:55:31 +00:00
5bf824ea10
convert TAB-based indentation in C sources to use only spaces
...
Done using this command (also includes .c.in and .h.in files):
for i in $(g ls-files|grep -E '\.[ch](\.in)?$'|grep -v gnulib); do
expand -i $i > j && mv j $i;done
2008-04-10 16:54:54 +00:00
dc42a9d2de
remove Vim and Emacs variable settings from C source files
...
Done with these commands:
git grep -l Local.variab|xargs \
perl -0x3b -pi -e 's,\n+/\*\n \* vim:(.|\n)*,\n,'
git grep -l Local.variab|xargs \
perl -0x3b -pi -e 's,\n+/\*\n \* Local variables:\n(.|\n)*,\n,'
2008-04-10 16:53:29 +00:00
3ceae485b2
AUTHORS and po updates
...
* AUTHORS: adding Dave Leskovec and Ryan Scott to the authors list
* po/*: rebuilt
daniel
2008-04-10 13:32:46 +00:00
c863713742
Ask xend to remove device in the config file too
...
* src/xend_internal.c: applied a patch from Ryan Scott to ask
xend to save the device removal change in the config file
Daniel
2008-04-10 13:30:17 +00:00
9ae41a71ac
* src/Makefile.am src/lxc_conf.c src/lxc_conf.h src/lxc_container.c
...
src/lxc_container.h src/lxc_driver.c: Applied second set of
linux container patches from Dave Leskovec adding start/stop
of domains
Daniel
2008-04-10 07:30:52 +00:00
a2c0fa5f5b
Add virsh.pod to EXTRA_DIST
...
* docs/Makefile.am: Add virsh.pod to EXTRA_DIST.
2008-04-09 15:12:13 +00:00
ed8a6d6a10
Core code contains Xen-ism UUID of dom0 = 0..0
...
* src/libvirt.c: Remove a Xen-ism from the core code, the
assumption that dom0's UUID is all zeroes.
2008-04-09 14:03:01 +00:00
c1bc644bad
Warn about conn, dom and net fields in virterror
...
* include/libvirt/virterror.h: Warn about the use of
conn, dom and net fields in virterror.
2008-04-09 14:00:07 +00:00
b5af30a9f3
Remove extraneous underscore
...
* src/openvz_conf.c: Remove extraneous underscore which stopped
file from compiling (Anton Protopopov).
2008-04-09 13:50:27 +00:00
5b470f32c3
0.4.2 release
...
* configure.in NEWS doc/* po/*: making libvirt-0.4.2 release
daniel
2008-04-08 16:45:57 +00:00
d2090e649b
configure.in (ALL_LINGUAS): Fix typo: s/Latn/latin/.
2008-04-08 15:53:16 +00:00
3ce465f819
Don't fail to read a file because it's non-seekable (e.g., a pipe).
...
* src/util.c (fread_file_lim): New function.
(__virFileReadAll): Use fread_file_lim, rather than requiring
that stat.st_size provide a usable file size.
* tests/read-non-seekable: New test, for the above.
* tests/Makefile.am (test_scripts): Add read-non-seekable.
* tests/test-lib.sh (mkfifo_or_skip_): New helper function.
2008-04-08 15:33:16 +00:00
407df0f164
src/qemu_driver.c: Handle errors from fork(2) and pipe(2)
...
system calls when creating qemu subprocess.
2008-04-08 12:27:53 +00:00
09f1c2041d
* po/sr.po po/sr@Latn.po po/sr@latin.po: fix/update serbian
...
translations.
daniel
2008-04-08 09:51:37 +00:00
801a8f2e7b
adds xen and hvm guest types to test driver capabilities
...
* src/test.c: patch from Cole Robinson adding xen and hvm guest types
to the test driver's capabilities.
Daniel
2008-04-08 09:26:24 +00:00
2579443e21
Fix potential infinite loop in python generator
...
* python/generator.py: fix an infinite loop bug
Daniel
2008-04-08 08:26:15 +00:00
7c61b48202
* tests/vcpupin: Add a test for the 2008-04-04 virsh.c bugfix.
2008-04-07 12:12:34 +00:00
67b17df9d2
update bugzilla URIs
...
* docs/bugs.html docs/libvir.html: update the page bugzilla URIs
depending on the set the user is running.
Daniel
2008-04-07 10:54:40 +00:00
d4a6fe9f99
Don't do polkit auth as root
2008-04-04 15:09:19 +00:00
62ee5d5711
error message on vcpupin
...
* src/virsh.c: patch from Shigeki Sakamoto adding message on vcpupin
Daniel
2008-04-04 11:20:45 +00:00
3a50451e84
doc and localization updates
...
* docs//* po/*: regenerated the documentation and reextracted the
full set of localization strings to push to the translation team.
Daniel
2008-04-04 08:06:18 +00:00
a528e97383
typos fixes
...
* docs//* src/conf.c src/hash.c src/libvirt.c src/proxy_internal.c
src/remote_internal.c src/virsh.c src/xen_internal.c
src/xend_internal.c src/xml.c: applied patch from Atsushi SAKAI
fixing a lot of typos
Daniel
2008-04-04 07:58:29 +00:00
7b72ef296f
virNodeGetCellsFreeMemory for test driver
...
* src/test.c: patch from Cole Robinson to add
virNodeGetCellsFreeMemory to the test driver
Daniel
2008-04-04 07:31:24 +00:00
dfc4b8a7d0
C99 initializer on __lastErr
...
* src/virterror.c: Use C99 initializers to make initialization
of __lastErr clearer (Guido Günther).
2008-04-02 16:22:34 +00:00
c2b690f1bd
* src/lxc_conf.c: patch from Dave Leskovec fixing an freed memory
...
access I introduced yesterday
Daniel
2008-04-01 13:01:01 +00:00
c7d7aa1cd1
remove dandling domain/net/conn pointers from error data
...
* src/hash.c src/internal.h src/virterror.c: remove dandling
domain/net/conn pointers from error data when released.
* src/lxc_driver.c: fix a NULL/0 return error mismatch
Daniel
2008-03-31 14:38:12 +00:00
be03daaab2
* configure.in: small patch from Mike Gerdts to avoid problems with
...
older awk implementations, fixes #439649
Daniel
2008-03-31 12:13:52 +00:00
497f252015
linux countainers cleanup patches
...
* src/lxc_conf.c src/lxc_conf.h: cleanup patch for the conf driver
of linux countainers, reuse XPath helpers, make string fields dynamic
and remove a memory leak.
* src/lxc_driver.c: avoid some problems when the config directory is
not accessible and for regression tests
Daniel
2008-03-31 12:02:12 +00:00
038b434f14
Added patches for routed networking from Mads Chr. Olesen
2008-03-28 20:38:21 +00:00
924de9c3d1
Fix output of XML for FS storage pool
2008-03-28 17:56:44 +00:00
b7909d3276
Tweak masquering rules to only capture traffic leaving the virtual network
2008-03-28 01:05:08 +00:00
c5adab5270
lxcError: mark a string and add to the list of nearly-checked functions
...
* Makefile.maint (msg_gen_function): Add, but commented-out.
* src/lxc_conf.c (lxcParseXML): Mark a diagnostic for translation.
2008-03-27 14:02:57 +00:00
76a7098407
testError: mark most string arguments for translation
...
* Makefile.maint (msg_gen_function): Add testError
* src/test.c (testDomainSave, testDomainRestore): Mark strings.
(testDomainCoreDump): Likewise.
2008-03-27 14:01:59 +00:00
7f8639261a
openvzLog: mark its string arguments for translation
...
* Makefile.maint (msg_gen_function): Add openvzLog.
* src/openvz_conf.c (openvzAssignVMDef, openvzParseXML): Mark strings.
* src/openvz_driver.c (openvzDomainShutdown, openvzDomainReboot):
(openvzDomainDefineXML, openvzDomainCreateLinux):
(openvzDomainCreate, openvzDomainUndefine): Likewise.
2008-03-27 14:00:28 +00:00
5bb81e1d87
error: mark most string arguments for translation
...
Also mark some arguments to __virRaiseError.
* Makefile.maint (msg_gen_function): Add error.
* po/POTFILES.in: Add src/openvz_conf.c and src/openvz_driver.c.
* src/openvz_conf.c (openvzParseXML, openvzGetVPSInfo): Mark strings.
* src/openvz_driver.c (openvzDomainLookupByID): Likewise.
(openvzDomainLookupByUUID, openvzDomainLookupByName): Likewise.
(openvzDomainGetInfo, openvzDomainShutdown, openvzDomainReboot)
(openvzDomainCreate, openvzDomainUndefine): Likewise.
* src/remote_internal.c (check_cert_file): Likewise.
(negotiate_gnutls_on_connection, verify_certificate): Likewise.
(remoteAuthenticate, addrToString, remoteAuthSASL): Likewise.
(remoteAuthPolkit, call, really_read_buf): Likewise.
2008-03-27 13:58:56 +00:00
f1eed04b2d
Convert diagnostics like "VAR > MAX_VAR" to translatable messages.
...
* src/remote_internal.c (errorf): New function.
(remoteListDomains, remoteDomainPinVcpu, remoteDomainGetVcpus):
(remoteListDefinedDomains, remoteListNetworks):
(remoteListDefinedNetworks): Convert strings to be translatable,
and also to include offending and maximum values. Use errorf.
2008-03-27 13:56:28 +00:00
b53c4e51f8
qemudReportError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add qemudReportError.
* src/qemu_conf.c (qemudLoadDriverConfig)
(qemudExtractVersion, qemudParseDiskXML, qemudParseInterfaceXML)
(qemudParseInputXML, qemudParseXML, qemudNetworkIfaceConnect)
(qemudBuildCommandLine, qemudSaveConfig, qemudParseVMDeviceDef)
(qemudAssignVMDef, qemudSaveVMDef, qemudSaveNetworkConfig)
(qemudParseDhcpRangesXML, qemudParseNetworkXML)
(qemudAssignNetworkDef, qemudSaveNetworkDef, qemudGenerateXML)
(qemudGenerateNetworkXML, qemudDeleteConfig): Mark strings.
* src/qemu_driver.c (qemudBuildDnsmasqArgv, qemudAddIptablesRules)
(qemudGetCapabilities, qemudDomainGetOSType)
(qemudListDefinedDomains, qemudListNetworks)
(qemudListDefinedNetworks, qemudNetworkGetBridgeName): Mark strings.
2008-03-27 13:53:14 +00:00
3163224bb5
ReportError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add ReportError.
* src/util.c (_virExec): Mark strings.
2008-03-27 13:47:00 +00:00
56a3cb8086
xenXMError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add xenXMError.
* src/xm_internal.c (xenXMParseXMLToConfig, xenXMDomainDefineXML):
(xenXMDomainAttachDevice, xenXMDomainDetachDevice): Mark strings.
2008-03-27 13:45:26 +00:00
513bd04ce1
Mark many more strings for translation.
...
* Makefile.maint (err_func_re): Add to the list and make it readable.
* po/POTFILES.in: Add src/util.c and src/xm_internal.c, and sort.
* src/storage_backend.c: Fix comment.
* src/util.c (virFileLinkPointsTo): Mark a string.
* qemud/remote.c (remoteDispatchClientRequest): Mark strings.
(remoteDispatchOpen, CHECK_CONN, remoteDispatchGetType): Likewise.
(remoteDispatchDomainGetSchedulerType): Likewise.
(remoteDispatchDomainGetSchedulerParameters): Likewise.
(remoteDispatchDomainSetSchedulerParameters): Likewise.
(remoteDispatchDomainBlockStats): Likewise.
(remoteDispatchDomainInterfaceStats): Likewise.
(remoteDispatchDomainAttachDevice, remoteDispatchDomainCreate):
(remoteDispatchDomainDestroy, remoteDispatchDomainDetachDevice):
(remoteDispatchDomainDumpXml, remoteDispatchDomainGetAutostart):
(remoteDispatchDomainGetInfo, remoteDispatchDomainGetMaxMemory):
(remoteDispatchDomainGetMaxVcpus, remoteDispatchDomainGetOsType):
(remoteDispatchDomainGetVcpus): Likewise.
(remoteDispatchDomainMigratePerform): Likewise.
(remoteDispatchListDefinedDomains, remoteDispatchDomainPinVcpu):
(remoteDispatchDomainReboot, remoteDispatchDomainResume):
(remoteDispatchDomainSave, remoteDispatchDomainCoreDump):
(remoteDispatchDomainSetAutostart): Likewise.
(remoteDispatchDomainSetMaxMemory, remoteDispatchDomainSetMemory):
(remoteDispatchDomainSetVcpus, remoteDispatchDomainShutdown):
(remoteDispatchDomainSuspend, remoteDispatchDomainUndefine):
(remoteDispatchListDefinedNetworks, remoteDispatchListDomains):
(remoteDispatchListNetworks, remoteDispatchNetworkCreate):
(remoteDispatchNetworkDestroy, remoteDispatchNetworkDumpXml):
(remoteDispatchNetworkGetAutostart, remoteDispatchNetworkGetBridgeName):
(remoteDispatchNetworkSetAutostart, remoteDispatchNetworkUndefine):
(addrToString, remoteDispatchAuthSaslInit, remoteDispatchAuthSaslStart):
(remoteDispatchAuthSaslStep, remoteDispatchListDefinedStoragePools):
(remoteDispatchListStoragePools, remoteDispatchStoragePoolCreate):
(remoteDispatchStoragePoolBuild, remoteDispatchStoragePoolDestroy):
(remoteDispatchStoragePoolDelete, remoteDispatchStoragePoolRefresh):
(remoteDispatchStoragePoolGetInfo, remoteDispatchStoragePoolDumpXml):
(remoteDispatchStoragePoolGetAutostart): Likewise.
(remoteDispatchStoragePoolSetAutostart):
(remoteDispatchStoragePoolListVolumes):
(remoteDispatchStoragePoolNumOfVolumes):
(remoteDispatchStoragePoolUndefine, remoteDispatchStorageVolCreateXml):
(remoteDispatchStorageVolDelete, remoteDispatchStorageVolGetInfo):
(remoteDispatchStorageVolDumpXml, remoteDispatchStorageVolGetPath):
(remoteDispatchStorageVolLookupByName): Likewise.
* src/qemu_driver.c (qemudOpenMonitor, qemudStartVMDaemon):
(dhcpStartDhcpDaemon, qemudStartNetworkDaemon):
(qemudDomainSuspend, qemudDomainResume, qemudDomainShutdown):
(qemudDomainGetOSType, qemudDomainSetMaxMemory):
(qemudDomainSetMemory, qemudDomainGetInfo, qemudDomainSave):
(qemudDomainRestore, qemudDomainDumpXML, qemudDomainStart):
(qemudDomainUndefine, qemudDomainChangeCDROM):
(qemudDomainAttachDevice, qemudDomainGetAutostart):
(qemudDomainSetAutostart, qemudDomainInterfaceStats):
(qemudNetworkLookupByUUID, qemudNetworkLookupByName):
(qemudNetworkUndefine, qemudNetworkStart, qemudNetworkDestroy):
(qemudNetworkDumpXML, qemudNetworkGetAutostart):
(qemudNetworkSetAutostart): Likewise.
* src/virsh.c (cmdVcpupin, cmdAttachDevice, cmdDetachDevice): Likewise.
* src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu): Likewise.
2008-03-27 13:43:01 +00:00
425cf2e792
Linux container fixes, move driver in the daemon.
...
* src/lxc_conf.c src/lxc_conf.h src/lxc_driver.c src/remote_internal.c:
applied patch from Dan Berrange to change the way the lxc driver
works, migrating the support in the daemon, it also removes some
compilation issues and teh way the configuration files are named.
Daniel
2008-03-27 09:34:06 +00:00
ae15bc7245
support of older versions of iscsiadm.
...
* src/storage_backend_iscsi.c: patch from Chris Lalancette to improve
support with older versions of iscsiadm.
Daniel
2008-03-27 08:11:27 +00:00
94c2255d81
* src/xen_internal.c proxy/libvirt_proxy.c: fix Xen hypercall for
...
Xen-3.2, and merged its debugging with the general library facility
Daniel
2008-03-26 13:03:30 +00:00
cedd94662d
Wed Mar 26 12:57:00 UTC 2008 Richard W.M. Jones <rjones@redhat.com>
...
* po/lt.po: Fixed typo (Beth Kon).
2008-03-26 13:00:47 +00:00
dc1824b780
Tue Mar 25 10:23:00 UTC 2008 Richard W.M. Jones <rjones@redhat.com>
...
* src/virsh.c: Additional error messages for missing
parameters (Shigeki Sakamoto).
2008-03-25 10:26:32 +00:00
928a84e10d
* src/qemu_driver.c: remove trailing newlines from error messages
...
patch from Guido Günther
Daniel
2008-03-24 10:58:21 +00:00
71c061d559
* src/qemu_driver.c: applied patch from Guido Günther to make error
...
strings as translatable
Daniel
2008-03-24 10:51:47 +00:00
b8fb14a905
* Makefile.maint (err_func_re): Add lxcError.
2008-03-24 10:21:46 +00:00
f4d2430d6c
* qemud/remote.c: Don't include <getopt.h>. Not used.
2008-03-24 10:21:03 +00:00
16fd2b6b61
Sync Makefile rules from coreutils.
...
* Makefile.maint: Merge.
* GNUmakefile: Update from coreutils.
2008-03-24 10:20:15 +00:00
f15efcdf27
Add new testing framework and the first test to use it.
...
* tests/Makefile.am (test_scripts): Add vcpupin.
(EXTRA_DIST): Add test-lib.sh.
* tests/test-lib.sh: Testing framework, from coreutils.
* tests/vcpupin: New file.
* build-aux/mktempd: New file, from gnulib.
* bootstrap: Add posix-shell and mktempd to the list of imported modules.
* gnulib/m4/posix-shell.m4: New file, from gnulib.
2008-03-24 10:19:36 +00:00
870dba07b1
Fix bugs in tests/Makefile.am.
...
* tests/Makefile.am (TESTS_ENVIRONMENT): Correct invalid
settings of abs_top_builddir and abs_top_srcdir.
Also prepend src/ to PATH, so we test the just-built virsh,
not whatever happens to be in the original $PATH.
2008-03-24 10:18:36 +00:00
979bb2bb67
* src/xend_internal.c: applied patch from Saori Fukuta adding the
...
scheduler API for the Xen daemon driver
* po/POTFILES.in: add the two new linux container modules
Daniel
2008-03-24 09:23:32 +00:00
f163895204
Initial Linux containers work
...
* configure.in include/libvirt/virterror.h src/Makefile.am
src/driver.h src/lxc_conf.[ch] src/lxc_driver.[ch] src/virterror.c:
Applied 3 patches from Dave Leskovec for intial support of
Linux containers, configured off by default, work in progress.
* src/libvirt.c: improve virDomainCreateLinux xmlDesc description
Daniel
2008-03-21 15:03:37 +00:00
ccb19376f7
* src/util.c src/util.h src/xml.c: applied patch from Hiroyuki Kaguchi
...
fixing Ethernet MAC addresses parsingand separating as an util
function, with added comments from Jim Meyering
Daniel
2008-03-20 11:24:30 +00:00
623ec4d2f2
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: applied patch
...
from Cole Robinson implementing memory operations for qemu driver
Daniel
2008-03-19 14:32:50 +00:00
2fe1c38796
Avoid "make syntax-check" failure.
...
* src/xen_unified.c: Remove trailing blank.
2008-03-18 22:33:01 +00:00
ea1c08e78d
Use explicit logic rules for opening Xen sub-drivers
2008-03-17 17:30:48 +00:00
a34bcb7829
Treat ENOTSUP like ENODATA, after failed fgetfilecon.
...
* src/storage_backend.c (virStorageBackendUpdateVolInfoFD): Treat a
failed fgetfilecon with errno == ENOTSUP the same as for ENODATA.
2008-03-17 16:57:21 +00:00
96c795328d
fixed DefinedDomains function comments c.f. 437216
...
* libvirt.c: fixed DefinedDomains function comments c.f. 437216
* docs/libvirt-*.xml docs/*/libvirt-libvirt.html: regenerated
Daniel
2008-03-17 16:43:54 +00:00
cefa185c1f
Fix creation of unmanaged pools
2008-03-17 15:10:48 +00:00
d8b363c35f
Cope with missing selinux attribute
2008-03-17 15:09:38 +00:00
ca7047f122
* src/libvirt.c docs/libvirt-*.xml docs/html/libvirt-libvirt.html:
...
fixed a few missing argument descriptions and regenerated.
Daniel
2008-03-17 10:48:02 +00:00
08ecf61b35
* NEWS virsh.1 docs//* include/libvirt/libvirt.h[.in] qemud/mdns.h
...
src/libvirt.c src/qemu.conf src/remote_internal.c src/xend_internal.c
tests/confdata/libvirtd.conf tests/confdata/libvirtd.out: patch from
Atsushi SAKAI fixing a ot more typo
Daniel
2008-03-17 10:27:31 +00:00
7ae13660cf
Don't set MAC on TAP devs. Pass TAP device name to QEMU
2008-03-14 20:30:03 +00:00
8885191702
* po/*: updated translations
...
Daniel
2008-03-14 15:57:02 +00:00
62b4c870aa
typo
...
* src/bridge.c: fix a typo in a comment
Daniel
2008-03-14 15:31:08 +00:00
a7892ee000
String fixes #436620
...
* qemud/qemud.c src/virsh.c: fixing some user facing strings
problems pointed out by Francesco Tombolini should fix #436620
Daniel
2008-03-14 15:21:15 +00:00
384f26525f
Small cleanup, Daniel
2008-03-14 11:14:41 +00:00
3e59e29859
Fix typo "informations" -> "information" (Atsushi SAKAI and
...
Saori FUKUTA).
2008-03-14 11:08:03 +00:00
adbf991a1d
* src/libvirt.c: virDomainSetSchedulerParameters need to be
...
blocked on read-only connections, patch from Saori Fukuta
Daniel
2008-03-13 09:27:46 +00:00
dc232cdf1b
* src/bridge.c src/virsh.c: typo fixes from Atsushi SAKAI
...
daniel
2008-03-13 09:21:41 +00:00
af1c7f96a8
* src/qemu_conf.c src/qemu_driver.c: patch from Cole Robinson
...
fixing CD Rom change on live QEmu/KVM domains.
Daniel
2008-03-13 09:17:45 +00:00
8d2d44ad05
Remove use of polkit-grant. Keep stdio open when running polkit-auth
2008-03-11 14:49:04 +00:00
c3501d4792
Don't force Xen connections to readonly when non-root
2008-03-11 14:25:49 +00:00
028e4a6116
Don't run cleannup code for parent process in daemon mode
2008-03-11 14:22:12 +00:00
f5ade63437
* docs/libvir.html docs/storage.html: apply documentation fixes
...
and typos cleanup from Atsushi Sakai
Daniel
2008-03-07 11:13:02 +00:00
d4cbf4c624
* src/xend_internal.c: applied patch from Cole Robinson to not
...
loose the boot tag when defining a fully virtualized xen domain
Daniel
2008-03-07 09:23:30 +00:00
2a4c20437d
Make iSCSI login actually work
...
* src/storage_backend_iscsi.c: Make iSCSI login actually work
(Chris Lalancette).
2008-03-04 20:02:34 +00:00
4d6a8a1c0a
Report error when vcpupin is given bad vCPU number.
...
* src/virsh.c: Report error when vcpupin is given bad vCPU number
(Shigeki Sakamoto).
2008-03-04 19:59:56 +00:00
869f8d0e7d
Also ignore leading zeros when comparing MAC addresses.
...
* src/util.c: Include <ctype.h>.
(TOLOWER): Define.
(__virMacAddrCompare): Rewrite to also ignore leading zeros.
2008-03-03 20:39:52 +00:00
65c4379c53
* src/capabilities.c: Cole Robinson pointed out a well formedness
...
problem when generating the capabilities in the test driver.
Daniel
2008-03-03 20:21:21 +00:00
4090a0870c
Don't use first byte of string as a pointer.
...
* src/qemu_conf.c (qemudReportError): Use the pointer, errorMessage,
not its first byte, errorMessage[0].
2008-03-03 18:11:16 +00:00
f9e94c2e13
Avoid segfault upon early libvirtd failure.
...
* qemud/qemud.c (main): Don't call qemudCleanup on an
uninitialized pointer.
2008-03-03 18:10:19 +00:00
6a17c6c652
Release of 0.4.1
...
* NEWS configure.in libvirt.spec.in docs/* include/libvirt/libvirt.h
po/*: preparing release of libvirt-0.4.1
Daniel
2008-03-03 14:42:37 +00:00
6272a7d0c2
Plug saslUsernameWhitelist leak.
...
* qemud/qemud.c (qemudCleanup): Free the array as well as
the strings in it.
2008-03-03 13:17:05 +00:00
cd6eefd3e8
Plug skipped-qemudCleanup leak.
...
* qemud/qemud.c (main): Call qemudCleanup also upon failure.
Otherwise, an error return would skip it and induce leaks.
2008-03-03 13:16:31 +00:00
ba8459e859
Plug remoteReadConfigFile leak.
...
* qemud/qemud.c (remoteReadConfigFile): Be careful to free
"conf" after a successful virConfReadFile.
2008-03-03 13:15:57 +00:00
1de5bace80
Plug two leaks: host.migrateTrans and arch.name
...
* src/capabilities.c (virCapabilitiesFree): Free host.migrateTrans.
(virCapabilitiesFreeGuest): Free arch.name member.
2008-03-03 13:15:14 +00:00
47a4c0fa0b
Plug virCapabilities*GuestDomain leak.
...
* src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type.
(virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt.
2008-03-03 13:14:26 +00:00
3e1aaf27fe
missing comments for _virDomainBlockStats fields
...
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in:
missing comments for _virDomainBlockStats fields
* docs/*: rebuilt docs
Daniel
2008-03-03 06:18:06 +00:00
39947cec85
fix a broken line split
...
* qemud/Makefile.am: fix a broken line split
Daniel
2008-02-29 17:02:41 +00:00
bb8340c18d
Many typos fixed (Atsushi SAKAI).
2008-02-29 12:53:10 +00:00
ba52fcbcdf
Rewrite test-coverage rules to accommodate multiple .o files per .c.
...
* src/Makefile.am (cov): Rewrite rule to merge gcov results corresponding
to two .o files: the libvirt_la- one, and the libvirt_test_la- one.
(tst): Remove unused rule.
* configure.in (LV_LIBTOOL_OBJDIR): Define and AC_SUBST.
2008-02-28 17:07:37 +00:00
9262d88e28
Avoid link errors with "configure --disable-shared".
...
* src/Makefile.am: Create a convenience library, libvirt_test.la,
and don't restrict access to *its* symbols.
* tests/Makefile.am (LDADDS): Add ../src/libvirt_test.la, so that
"configure --disable-shared" no longer provokes link errors.
(LIBVIRT): Remove definition.
(LDADDS): Remove use.
($(LIBVIRT)): Remove rule.
(LDADDS): Use the new convenience library instead.
(CLEANFILES): Define.
* docs/examples/index.py (dump_Makefile): Append $(COVERAGE_LDFLAGS),
to the LDADDS definition, to avoid link error with the combination of
--enable-test-coverage and --disable-shared.
* docs/examples/Makefile.am: Regenerate.
* docs/examples/index.html: Likewise.
* qemud/Makefile.am (libvirtd_LDFLAGS): Append $(COVERAGE_LDFLAGS).
* src/libvirt_sym.version: Remove some SP-before-TAB.
2008-02-28 17:06:32 +00:00
004ff90483
Fix qemudReportError.
...
* src/qemu_conf.c: applied patch from Cole Robinson to use virErrorMsg
in qemudReportError.
Daniel
2008-02-28 11:17:49 +00:00
9699e372c2
Set MAC address on TUN device for Xenner compatability
2008-02-28 01:23:14 +00:00
46b427a310
Make qemud/'s rpcgen rules work.
...
* qemud/Makefile.am (SUFFIXES): Define to .x before implicit rule.
2008-02-27 19:12:58 +00:00
92a1e14b0b
virMacAddrCompare for comparing MAC addresses
...
* src/util.c, src/util.h, src/libvirt_sym.version: Added
virMacAddrCompare utility function for comparing MAC
addresses.
* src/virsh.c, src/xm_internal.c: Use virMacAddrCompare
to compare addresses. (Shigeki Sakamoto and Richard Jones).
2008-02-27 16:14:44 +00:00
fa4ab3325b
Avoid "make distcheck" failure.
...
* src/Makefile.am (virsh_SOURCES): Add util-lib.h.
2008-02-27 15:17:45 +00:00
d7cdc28431
Fix a "make syntax-check" failure.
...
* src/capabilities.c: Include <config.h> from the .c file,
* src/capabilities.h: ... not from the .h file.
2008-02-27 14:40:19 +00:00
b4882504ea
Fix typos (Atsushi SAKAI).
2008-02-27 10:37:19 +00:00
63bc5dd3e1
Add formal internal capabilities API and update drivers to use it
2008-02-27 04:35:08 +00:00
727c5601ec
Implement virDomainBlockStats for QEMU/KVM.
...
* src/qemu_driver.c: Implement virDomainBlockStats for QEMU/KVM
using QEMU/KVM 'info blockstats' command (Richard Jones).
* src/qemu_driver.c, src/qemu_conf.h: const-correctness
fixes (Jim Meyering).
2008-02-26 18:41:43 +00:00
242fe3d401
No address attribute in Xen domain XML.
...
* src/xm_internal.c: handle the case where <mac/> clause
in Xen domain interface has no address attribute
(Shigeki Sakamoto).
2008-02-26 18:31:57 +00:00
36c6bfa63d
* src/driver.h src/libvirt.c src/openvz_driver.c src/qemu_driver.c
...
src/remote_internal.c src/test.c src/util.c src/util.h
src/xen_unified.c: added probe interface at the driver level,
use that to improve default hypervisor selection in the absence
of a given URI when connecting
Daniel
2008-02-26 07:05:18 +00:00
9b1cd481b8
fix compilation against static libraries
...
* src/Makefile.am src/util-lib.h: fix done with Jim to allow
compilation of virsh with the static libraries.
Daniel
2008-02-25 13:55:56 +00:00
e497deb89e
Avoid new "make syntax-check" failures.
...
* .x-sc_avoid_write: Exempt src/util-lib.c, too.
* Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
* src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
Use safewrite, not write.
* src/storage_backend_logical.c (virStorageBackendLogicalBuildPool): Likewise.
2008-02-25 10:00:16 +00:00
b1b23f76be
avoid format string warnings
...
Avoid warnings like this:
file:nnn:format not a string literal and no format arguments
* qemud/qemud.c: Insert a "%s" format argument.
* qemud/remote.c: Likewise.
* src/iptables.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/storage_backend.c: Likewise.
* src/storage_backend_fs.c: Likewise.
* src/storage_backend_iscsi.c Likewise.
* src/storage_backend_logical.c: Likewise.
* src/storage_conf.c: Likewise.
* src/storage_driver.c: Likewise.
2008-02-22 16:26:13 +00:00
b59d9c85f1
Use safewrite in place of write, in many cases.
...
Also add "make syntax-check" rules to ensure no new uses sneak in.
There are many uses of write like this:
if (write (fd, xml, towrite) != towrite)
return -1;
The problem is that the syscall can succeed, yet write less than
the requested number of bytes, so the caller should retry
rather than simply failing.
This patch changes most of them to use util.c's safewrite wrapper,
which encapsulates the process. Also, there were a few cases in
which the retry loop was open-coded, and I replaced those, too.
* Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
* .x-sc_avoid_write: New file. Record two legitimate exemptions.
* qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
* src/conf.c (__virConfWriteFile): Likewise.
* src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
* src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
(qemudVMData, PROC_IP_FORWARD): Likewise.
* proxy/libvirt_proxy.c: Include "util.h".
(proxyWriteClientSocket): Use safewrite.
* src/test.c (testDomainSave, testDomainCoreDump): Likewise.
* src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
* src/virsh.c: Include "util-lib.h".
(vshOutputLogFile): Use safewrite.
* src/console.c: Include "util-lib.h".
(vshRunConsole): Use safewrite.
2008-02-22 15:55:04 +00:00
a178a4e7bf
Move safewrite and saferead to a separate file.
...
We currently use safewrite from inside libvirt and don't want to publish
any such function name. However, we do want to use it in applications
like virsh, libvirtd and libvirt_proxy that link with libvirt. To that
end, this change moves that function definition (along with the nearly
identical saferead) into a new file, util-lib.c. To avoid maintaining
separate copies of even such small functions, we simply include that new
file from util.c. Then, the separate applications that need to use
safewrite simply compile and link with util-lib.c.
Of course, this does mean that each of those applications will
containing two copies of these functions. However, the functions
are so small that it's not worth worrying about that.
* src/util.c (saferead, safewrite): Move function definitions to
util-lib.c and include that .c file.
* src/util-lib.c (saferead, safewrite): New file. Functions from src/util.c
with slight change (s/int r =/ssize_t r =/) to reflect read/write return type.
* src/util-lib.h: Declare the two moved functions.
* src/util.h: Remove declarations. Include src/util-lib.h.
* proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c.
* qemud/Makefile.am (libvirtd_SOURCES): Likewise.
* src/Makefile.am (virsh_SOURCES): Add util-lib.c. Remove some SP-before-TAB.
2008-02-22 15:53:13 +00:00
6187c6de9b
With --enable-iptables-lokkit=no, avoid warning about unused parameter.
...
* src/iptables.c (iptRulesSave) [!ENABLE_IPTABLES_LOKKIT]:
Mark parameter as used.
2008-02-22 12:34:27 +00:00
bdbce64bab
With --without-xen, avoid warning about unused function.
...
* tests/statstest.c (testQuietError) [!WITH_XEN]: Don't define.
2008-02-22 12:33:47 +00:00
9bcade46df
Rewrite openvzSetUUID.
...
* src/openvz_conf.c (openvzSetUUID): Rewrite to avoid unchecked
lseek, write, and close as well as a potential file descriptor leak.
2008-02-21 18:48:06 +00:00
5fc07cd840
Handle failed openvzLocateConfDir.
...
* src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID):
(openvzSetUUID): Don't dereference NULL upon failure.
2008-02-21 18:22:45 +00:00
be8653b183
Fix double-free in OpenVZ driver.
...
* src/openvz_conf.c: Double-free fix (Anton Protopopov).
2008-02-21 15:20:36 +00:00
83d0aa0706
Added missing symbol export
2008-02-21 03:53:03 +00:00
c8c473c053
Avoid "make syntax-check" failure.
...
* docs/examples/index.py: Don't emit trailing blanks.
* docs/examples/Makefile.am: Regenerate.
2008-02-20 17:26:01 +00:00
104cc98636
Update to work with new policy kit APIs
2008-02-20 16:54:35 +00:00
caad8777e0
Update po files with latest translatable strings
2008-02-20 16:08:56 +00:00
8b6b21d41c
Added docs on storage management capabilities
2008-02-20 15:58:06 +00:00
Jim Meyering