libvirt

Commit Graph

Author	SHA1	Message	Date
Michal Privoznik	4a457adda6	tests: Self test virt-admin Just like we are running 'virsh self-test' from within our test suite, we should run 'virt-admin self-test' too. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>	2016-09-14 13:18:07 +02:00
Erik Skultety	419bc8cf65	tests: fix incorrect status handling by virsh-self-test The virsh-self-test script compared the test's return code with 1 and only if the return code matched this value then the test was marked as failed. Problem is that SIGSEGV returns 139 (or 11 to be precise, since shell reserves the MSB for abnormal exit signaling) which passes the check just fine and test then appears as successful which it most certainly wasn't. Therefore, flip the logic to compare against 0 instead and every other result will be treated as a failed test case. Signed-off-by: Erik Skultety <eskultet@redhat.com>	2016-09-13 15:19:39 +02:00
Ján Tomko	920ab8bdce	Introduce virsh self-test A new hidden command for virsh that will iterate over all command groups and commands and print help for every single one. This involves running vshCmddefOptParse so we can get an error if one of the command's option structure is invalid.	2016-06-20 18:16:33 +02:00

Author

SHA1

Message

Date

Michal Privoznik

4a457adda6

tests: Self test virt-admin

Just like we are running 'virsh self-test' from within our test
suite, we should run 'virt-admin self-test' too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

2016-09-14 13:18:07 +02:00

Erik Skultety

419bc8cf65

tests: fix incorrect status handling by virsh-self-test

The virsh-self-test script compared the test's return code with 1 and only if
the return code matched this value then the test was marked as failed. Problem
is that SIGSEGV returns 139 (or 11 to be precise, since shell reserves the MSB
for abnormal exit signaling) which passes the check just fine and test then
appears as successful which it most certainly wasn't.
Therefore, flip the logic to compare against 0 instead and every other result
will be treated as a failed test case.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

2016-09-13 15:19:39 +02:00

Ján Tomko

920ab8bdce

Introduce virsh self-test

A new hidden command for virsh that will iterate over
all command groups and commands and print help for every single one.

This involves running vshCmddefOptParse so we can get an error if
one of the command's option structure is invalid.

2016-06-20 18:16:33 +02:00

3 Commits