60623a7ce0
Add support for a non-template filesystem root. (Florian Vichot)
2009-03-24 10:59:13 +00:00
aac6018a35
fix missing authentication on virsh shell commands
...
* src/virsh.c: fix missing authentication when command are issued
from the shell, patch by Matthias Bolte
Daniel
2009-03-23 16:36:32 +00:00
de4950b200
* src/util.c: flag unused parameters, by Maximilian Wilhelm
...
daniel
2009-03-20 20:46:07 +00:00
c29d092905
use posix_fallocate() to allocate diskspace faster
...
* src/libvirt_private.syms src/storage_backend_fs.c src/util.c
src/util.h: use posix_fallocate() on supported systems to
allocate diskspace faster, patches by Amit Shah
Daniel
2009-03-20 12:17:56 +00:00
b75a469852
More flexible setup of QEMU capabilities/emulators
2009-03-20 11:20:26 +00:00
c86afc85ee
Fix labelling of shared/readonly devices (Dan Walsh)
2009-03-17 11:35:40 +00:00
df59fdce06
* src/remote_internal.c: remove file descriptors leak
...
daniel
2009-03-17 11:00:56 +00:00
b68a19be0f
Don't allow readonly connections to dump secure xml.
2009-03-16 17:21:12 +00:00
2068f2f5a3
Initialize security driver after config parsing
2009-03-16 17:16:04 +00:00
d2c77e06c7
Fix test driver 'save' deadlock
2009-03-16 17:14:34 +00:00
b44af714d3
Support SASL auth for VNC server.
2009-03-16 13:54:26 +00:00
8fa62166c4
Avoid deadlock setting vcpus in QEMU driver
2009-03-16 11:44:46 +00:00
35625e5aa8
Fix subsystem lookup for older HAL releases
2009-03-16 10:56:01 +00:00
aa08419ca8
Avoid some potential FILE * leaks
...
* qemud/qemud.c src/cgroup.c src/uml_driver.c src/util.c: close
some potential FILE * leaks
Daniel
2009-03-16 10:41:37 +00:00
2567fac4a7
Don't free storage volume in cleanup path, since it may still be referenced
2009-03-16 10:31:38 +00:00
aad6873175
Don't try to close NULL virConnectPtr object
2009-03-16 10:30:04 +00:00
a3262d812b
* src/storage_conf.c: fix storage pool mode parsing, and refactoring
...
patch by Ryota Ozaki
Daniel
2009-03-12 20:15:32 +00:00
bdd6894713
* src/xs_internal.c: fix xen events handling problem (Dan Berrange)
...
Daniel
2009-03-11 13:43:24 +00:00
27a63a76af
* src/xend_internal.c: fix an allocation problem in xenDaemonDomainLookupByName_ids
...
Daniel
2009-03-10 11:13:32 +00:00
4dfb7e8b2e
Fix Xen block detach with newer Xend (Cole RobinSon / Tomohiro Takahashi)
2009-03-10 10:32:24 +00:00
7f39e2e5e5
* src/cgroup.c src/cgroup.h src/lxc_driver.c: allows to get
...
CPU usage of a lxc using cpuacct subsystem of cgroups, patch
by Ryota Ozaki
Daniel
2009-03-06 14:44:04 +00:00
4ebe4c108d
Fix misc failures in test suite & make test cases more robust to future changes
2009-03-04 13:04:06 +00:00
b9739b4709
Add missing locking calls in remote driver
2009-03-03 19:33:34 +00:00
3aed672836
Use lseek+saferead/write for pci.c & dont link to qemu driver for nodedevxml2xmltest
2009-03-03 17:00:18 +00:00
61796bdb4b
Explicitly track static declared vs dynamically generated security labels
2009-03-03 16:53:13 +00:00
e4818895c1
Misc sVirt bug fixes
2009-03-03 15:18:24 +00:00
efa5832b0a
config: fix a typo
...
* src/qemu_conf.c (CHECK_TYPE): Fix typo:
s/security_river/security_driver/
2009-03-03 15:12:30 +00:00
d0aa10fdd6
QEMU security driver usage for sVirt support (James Morris, Dan Walsh, Daniel Berrange)
2009-03-03 12:03:44 +00:00
b756b005ec
Replace use of qemudLog with logging.h APIs/macros
2009-03-03 11:40:08 +00:00
10e3148f0a
avoid file descriptor leak when fd == 0
...
* src/pci.c (pciGetDevice): Initialize dev->fd to -1, not 0.
(pciFreeDevice): Close fd also when it is 0.
2009-03-03 11:25:52 +00:00
8343dcb893
don't leak a file descriptor on failed pciGetDevice call
...
* src/pci.c (pciIterDevices): Always close dir handle.
2009-03-03 11:25:35 +00:00
41ed6eb327
SELinux security driver for sVirt support (James Morris, Dan Walsh & Daniel Berrange)
2009-03-03 10:06:49 +00:00
aa2c97263d
virsh additions for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:59:02 +00:00
8bd1604cb7
Core internal driver stub for sVirt support (Jams Morris & Dan Walsh)
2009-03-03 09:44:41 +00:00
a8cd24b346
Remote protocol / RPC API for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:27:02 +00:00
8d13558ae6
Internal driver API for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:14:28 +00:00
0b7860ecdd
Public API for sVirt support (James Morris & Dan Walsh)
2009-03-03 09:09:00 +00:00
8f1912c58d
Don't try to detach & reset PCI devices while running test suite for XML-> ARGV conversion.
2009-03-03 08:59:45 +00:00
72652e9dbb
Always reset PCI devices
2009-03-02 20:22:35 +00:00
644b41a94d
Export virUnrefConnect & virCapabilitiesGenerateMac to driver code
2009-03-02 20:19:13 +00:00
9883bec50d
virsh: tweak a format string to avoid emitting trailing space
...
* src/virsh.c (cmdNetworkList): Change format not to right-pad
with spaces, as that would have required a trailing blank in
an expected output file.
2009-03-02 18:39:36 +00:00
aedf57db70
Fix bridge generation loop counter (spotted by Jim Meyering)
2009-03-02 17:56:50 +00:00
f9cbf065ad
Recognize ejectable media in hostdev hal driver.
2009-03-02 17:41:13 +00:00
4837725f37
Better error reporting from qemu AttachDevice
2009-03-02 17:39:43 +00:00
1f11e3bb61
Generate network bridge names if none passed at define/create time.
2009-03-02 17:37:03 +00:00
adecc8fc9e
Remove redundant monitor watch variable (s/monitor_watch/monitorWatch/)
2009-03-02 17:33:39 +00:00
895247b76b
Mark 'defined' networks as persistent.
2009-03-02 17:29:44 +00:00
09fb8845a7
adds a new <hostdev managed='(yes|no)'> property to host devices in domains
...
* docs/schemas/domain.rng src/domain_conf.c src/domain_conf.h
src/qemu_conf.c
tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.xml:
adds a new <hostdev managed='(yes|no)'> property
to host devices indicating whether or not we should
automatically dettach/reset, patch by Mark McLoughlin
daniel
2009-03-02 16:40:30 +00:00
34d23b0b01
* src/qemu_driver.c: add qemu dettach/reattach/reset implementation
...
patch by Mark McLoughlin.
Daniel
2009-03-02 16:32:52 +00:00
0231102863
Implement node attach/reattach/reset in the remote driver
...
* qemud/remote.c qemud/remote_dispatch_args.h
qemud/remote_dispatch_prototypes.h qemud/remote_dispatch_table.h
qemud/remote_protocol.c qemud/remote_protocol.h
qemud/remote_protocol.x src/remote_internal.c: Implement
attach/reattach/reset in the remote driver, patch by Mark
McLoughlin.
Daniel
2009-03-02 16:30:59 +00:00
6427091ffe
* src/virsh.c: add 3 new commands for node device detach, reattach and reset,
...
patch by Mark McLoughlin.
Daniel
2009-03-02 16:28:17 +00:00
737af2ea04
Adds the APIs for virNodeDeviceDettach , ReAttach and Reset
...
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in
src/driver.h src/libvirt.c src/libvirt_public.syms
src/lxc_driver.c src/openvz_driver.c src/qemu_driver.c
src/test.c src/uml_driver.c: add the public APIs for
virNodeDeviceDettach virNodeDeviceReAttach and virNodeDeviceReset
and extends the driver structure accordingly.
Daniel
2009-03-02 16:25:13 +00:00
d217641314
implements dettach, reattach and reset for PCI devices
...
* configure.in po/POTFILES.in src/Makefile.am src/libvirt_private.syms
src/pci.c src/pci.h: Add implementations of dettach, reattach and
reset for PCI devices, patch by Mark McLoughlin
Daniel
2009-03-02 16:18:11 +00:00
a3ce3b1c71
* qemud/qemud.c src/node_device_hal.c: activate DBus multithreading
...
to avoid random crashes in the daemon, patch by Daniel Berrange
Daniel
2009-03-02 11:13:37 +00:00
14dfe93965
correct a typo in a diagnostic
...
* src/storage_conf.c (virStorageVolDefParsePerms): Correct a typo:
s/owner/group/. Patch by Ryota Ozaki.
2009-03-02 10:27:20 +00:00
0fe3340ed9
plug two config-parsing leaks
...
* src/storage_conf.c (virStoragePoolDefParsePerms): Free mode string.
(virStorageVolDefParsePerms): Likewise.
* AUTHORS: Update.
Patch by Ryota Ozaki.
2009-03-02 10:26:37 +00:00
07696eb347
don't dereference uninitialized pointer
...
* src/storage_conf.c (virStoragePoolDefParsePerms): Initialize
"ptr" to NULL.
2009-03-02 10:07:55 +00:00
014bb5cf7e
If there is a failure during Qemu offline migrate, make sure to resume the
...
guest.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2009-02-27 16:18:50 +00:00
2e187bcbca
Add support for a exec callback in virExecWithHook
2009-02-26 16:27:51 +00:00
372d5b3088
* src/remote_internal.c: fix autostart of session daemon, patch
...
by Dan Berrange
Daniel
2009-02-26 15:06:06 +00:00
299aefebf2
* src/storage_backend_fs.c: fix compile-error when configured without qemu-img
...
daniel
2009-02-26 14:36:30 +00:00
c4c5e9dbbb
Add virNodeDeviceDefParseString()
...
Add support for parsing node device XML descriptions.
This will be used by PCI passthrough related functions to
obtain the PCI device address for a given node device.
2009-02-24 14:55:45 +00:00
ee197521c5
Add virXPathULongLong()
...
Add a variant of virXPathULong() which can handle long longs.
Needed for parsing storage device capacities.
2009-02-24 14:54:30 +00:00
c56b4bcbf3
Add virXPathLongHex() and virXPathULongHex()
...
Add new functions to allow parsing integers with base 16
This will be used to e.g. parse PCI vendor IDs.
2009-02-24 14:53:30 +00:00
761f5a52dc
networkEnableIpForwarding() now returns zero for success
2009-02-22 11:19:54 +00:00
4cbe86fcb8
(s)size_t type cleanup
2009-02-19 08:18:31 +00:00
7e8ad2036a
Remove the _actually_ incorrect ATTRIBUTE_UNUSED (Patch by Maximilian Wilhelm)
2009-02-18 01:37:47 +00:00
cf47347312
Remove incorrect ATTRIBUTE_UNUSED usage.
2009-02-17 14:38:22 +00:00
73619269ae
Build fix for 'driver.c' when building with loadable modules
...
The 'asprintf' -> 'virAsprintf' transition made in
[043d702f
2009-02-17 10:43:26 +00:00
64b72210ad
Work around 'virGetVersion' build problem
...
The 'getVer' fix introducted in d88d459d
2009-02-17 10:33:41 +00:00
cedc15019e
avoid compiler warning about unused parameter
...
* src/bridge.c (brProbeVnetHdr)
[IFF_VNET_HDR && TUNGETFEATURES && TUNGETIFF]: Use a "(void)" case
to mark the parameter as unused. Reported by Maximilian Wilhelm in
http://thread.gmane.org/gmane.comp.emulators.libvirt/11918/focus=11917
2009-02-17 10:26:43 +00:00
bdd5094d8f
accommodate configuring --without-lxc --without-qemu
...
* configure.in: Enable internal WITH_BRIDGE support not just for LXC or
QEMU, but also for --with-network. Russell Haering reported that
compilation failed when configured with --without-lxc --without-qemu.
Details: http://thread.gmane.org/gmane.comp.emulators.libvirt/11928
* src/bridge.h: Use #if WITH_BRIDGE, rather than currently-equivalent
"#if defined(WITH_QEMU) || defined(WITH_LXC)"
2009-02-17 10:23:19 +00:00
4dce547640
Fix I/O errors in libvirtd daemon, and hang/crash in remote client upon I/O error
2009-02-17 09:44:18 +00:00
3a53ab7913
Unbreak virsh *-edit commands: Don't pass unexpected flags to DumpXML
2009-02-16 22:51:31 +00:00
c482439232
Remove erroneous lvm volume format check for backing store.
2009-02-16 22:47:19 +00:00
0bb6f816e3
Add virFileWriteStr()
...
Re-factor the code from networkEnableIpForwarding() into a
utility function in preparation for code which writes to
sysfs files.
2009-02-13 19:13:06 +00:00
f6a5e8f785
Fix some error strings in xml.c
...
Just some copy-and-paste mixups.
2009-02-13 19:12:45 +00:00
c4602255c7
virXPathInt() and virXPathUInt() don't exist
...
It looks like these functions have never existed.
2009-02-13 19:12:20 +00:00
9fec27be49
Fix bridge.c warnings with gcc-4.4
...
bridge.c: In function 'brSetInetAddr':
bridge.c:665: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
bridge.c:665: note: initialized from here
bridge.c:666: error: dereferencing pointer '({anonymous})' does break strict-aliasing rules
bridge.c:666: note: initialized from here
Fix qemud.c warnings with gcc-4.4
qemud.c: In function ‘remoteListenTCP’:
qemud.c:675: error: dereferencing pointer ‘sa.72’ does break strict-aliasing rules
qemud.c:675: note: initialized from here
qemud.c:678: error: dereferencing pointer ‘sa.73’ does break strict-aliasing rules
qemud.c:678: note: initialized from here
2009-02-13 19:10:55 +00:00
7d2b7ad520
Fix migrate for Xen 3.3
2009-02-13 18:23:23 +00:00
f98b9e05d8
test:///default driver: don't dereference NULL "def"
...
* src/test.c (testNetworkCreate, testNetworkDefine): Since "def" is
set to NULL immediately after any vir*AssignDef call (to indicate we
no longer own it and to ensure no clean-up path mistakenly frees it),
dereference via net->def->, not def->.
2009-02-13 18:11:03 +00:00
6efe591e66
usleep to wait for domain logfile to fill up
2009-02-13 11:35:16 +00:00
e9c920ba67
fix return status when domain didn't show up
2009-02-11 20:33:11 +00:00
f84c166013
Improve error reporting in virsh
2009-02-09 14:24:06 +00:00
fa7f51b813
introduce virSaveLastError(), virFreeError()
2009-02-09 14:16:23 +00:00
1290b28f59
Limit virsh history entries to 500 (Jim Paris)
2009-02-09 10:24:27 +00:00
0437e75291
Don't ignore errors to save domain status
2009-02-07 21:36:06 +00:00
31135bff29
src/domain_conf.c: Check the last error, not the last
...
connection error, which may not have been set.
2009-02-05 19:29:37 +00:00
003f354917
xenstore: Use virMacAddrCompare() for case-insensitive comparison
2009-02-05 18:14:00 +00:00
b8b4fd4c7d
report error for some xend operations on shutdown domain
2009-02-05 17:24:51 +00:00
bc68ae8060
robustify sexpr parser for NICs
2009-02-05 17:17:33 +00:00
bafd7389e4
remove remainder of offending strerror uses
...
* qemud/qemud.c (GET_CONF_STR): Use virStrerror, not strerror.
* qemud/remote.c (remoteDispatchDomainBlockPeek): Likewise.
(remoteDispatchDomainMemoryPeek, remoteDispatchAuthSaslInit): Likewise.
(remoteDispatchAuthPolkit): Likewise.
* src/lxc_container.c (lxcContainerAvailable): Likewise.
* src/network_driver.c (networkStartNetworkDaemon): Likewise.
(networkShutdownNetworkDaemon): Likewise.
* src/qemu_conf.c (qemudExtractVersion, qemudNetworkIfaceConnect):
* src/storage_conf.c (virStoragePoolLoadAllConfigs): Likewise.
* src/storage_driver.c (storagePoolUndefine): Likewise.
* src/uml_driver.c (umlStartup, umlStartVMDaemon): Likewise.
* src/util.c (virFileReadAll): Likewise.
* src/uuid.c (virUUIDGenerate): Likewise.
* src/xen_internal.c (get_cpu_flags): Likewise.
2009-02-05 16:28:30 +00:00
d22a844b46
don't include raw errno in diagnostics
...
* src/uml_driver.c (umlStartVMDaemon): Don't print raw errno value.
* qemud/remote.c (remoteDispatchAuthSaslInit): Likewise.
2009-02-05 16:28:15 +00:00
1e31bfb055
iptables.c: Use virStrerror, not strerror.
...
* src/iptables.c: Include "virterror_internal.h".
Use virStrerror, not strerror.
* src/iptables.c (notifyRulesUpdated): Use %s rather than
string-concatenation that made sc_unmarked_diagnostics report
a false-positive.
2009-02-05 16:27:51 +00:00
dcfa920aff
use virReportOOMError rather than more verbose equivalent
...
* src/qemu_driver.c (qemudDomainSave, qemudDomainRestore)
(qemudDomainAttachPciDiskDevice)
(qemudDomainAttachUsbMassstorageDevice):
2009-02-05 16:27:40 +00:00
e60430be53
qemu_driver.c: s/strerror/virStrerror.../
...
Perform most changs automatically, with this:
perl -pi -e 's/\bstrerror *\((.+?)\)/virStrerror($1, ebuf, sizeof ebuf)/'
Then, declare ebuf, as needed
2009-02-05 16:27:28 +00:00
b0d49913d5
remove duplicate *SetCloseExec and *SetNonBlock functions
...
* src/qemu_driver.c: Use virSetCloseExec and virSetNonBlock,
rather than qemuSet* functions. Suggested by Daniel P. Berrange.
* src/util.c (virSetCloseExec): Publicize.
* src/util.h (virSetCloseExec): Declare
* src/libvirt_private.syms: Add virSetCloseExec.
2009-02-05 16:27:17 +00:00
caea9c00e3
qemu_driver.c: use virReportSystemError in place of some qemudLog uses
...
...thus eliminating many uses of strerror.
(kvmGetMaxVCPUs): Rather than merely warning, diagnose an error
and return -1 upon failure to open KVM_DEVICE. Suggested by
Daniel P. Berrange.
2009-02-05 16:11:25 +00:00
7bc569dda9
publicize virStrerror
...
* src/virterror.c (virStrerror): Remove "static".
* src/virterror_internal.h (virStrerror): Declare it.
* src/libvirt_private.syms: Add virStrerror;
2009-02-05 16:10:07 +00:00
a9aa76bad5
remove useless code
...
* src/bridge.c (brAddTap): Remove redundant errno=ENOMEM assignment
after failed strdup.
* src/cgroup.c (virCgroupFree): Remove redundant *group=NULL assignment
after VIR_FREE(*group).
* src/lxc_driver.c (lxcShutdown): Likewise.
* src/xen_unified.c (xenUnifiedClose): Likewise.
* src/xm_internal.c (xenXMDomainConfigFormat): Rewrite disk-
and net-config-setting code to be clearer.
2009-02-05 16:03:11 +00:00
7faa50d1db
lxc_container: Don't dereference NULL upon failure
...
* src/lxc_container.c (lxcContainerPivotRoot): Free and zero
oldroot *after* printing the diagnostic, both for virFileMakePath
and pivot_root failure.
2009-02-05 15:28:19 +00:00
6778ad0f07
avoid a format-related warning
...
* src/qemu_driver.c (qemudStartVMDaemon): Use "%s".
2009-02-03 13:09:18 +00:00
dff2114795
build: enable redundant-const check
...
* Makefile.cfg (local-checks-to-skip): Remove sc_redundant_const.
* src/lxc_controller.c: Remove redundant "const"(s).
* src/storage_backend_fs.c: Likewise.
* src/util.h: Likewise.
* src/xen_internal.c: Likewise.
* tests/qparamtest.c: Likewise.
2009-02-03 13:08:59 +00:00
c18ccff446
cleanup: remove useless if-before-VIR_FREE
...
* Makefile.cfg (useless_free_options): Also check for VIR_FREE.
* src/iptables.c (iptRulesFree): Remove useless if-before-VIR_FREE.
* src/remote_internal.c (remoteAuthSASL): Likewise.
* src/test.c (testOpenFromFile): Likewise.
2009-02-03 13:08:07 +00:00
66929686c4
fix more printf("%s", NULL) cases
2009-02-02 18:41:56 +00:00
e69b20d616
Don't hardcode ssh port 22, use VIR_FREE, initialize pointers to NULL not 0.
2009-01-31 13:49:11 +00:00
f92e9f599b
Fix empty declaration in enum declaration
2009-01-30 21:52:22 +00:00
a119a98081
fix qemud version reporting when qemu is not installed
...
* src/qemu_conf.c (uname_normalize): New function, factored out of...
(qemudBuildCommandLine): ...here. Use the new function.
(qemudExtractVersion): Use it here, rather than hard-coding "i686".
2009-01-30 19:57:20 +00:00
a6ef2e0055
Fix ifname= passing to QEMU for type=ethernet network config
2009-01-30 17:17:58 +00:00
67e7416119
Support disk caching mode config
2009-01-30 17:15:39 +00:00
3cb55cb51f
Fix crash using bogus arch in QEMU
2009-01-30 17:12:28 +00:00
896761e5c7
Fix numerous bugs in QEMU domain startup
2009-01-30 17:07:29 +00:00
05436ab7ff
Fix valgrind crash in LXC & avoid probing unneccessarily
2009-01-30 16:51:33 +00:00
d8637214a4
Fix leak of storage vols when freeing pool
2009-01-30 16:48:52 +00:00
745c249a61
Fix yet another printf("%s", NULL) case
...
Fix getpwuid_r() usage
Fix virsh migrateuri handling
2009-01-30 15:43:05 +00:00
1c64dc76c1
Misc xen driver bug/crash fixes
2009-01-29 23:01:37 +00:00
3a8d93ab36
Fix xend XML generation when CPU pinning is used
2009-01-29 18:40:32 +00:00
3801794908
Support VNC password setting in QEMU driver
2009-01-29 17:50:00 +00:00
4f4bfbc79e
Fix save/restore migrate syntax for new KVM releases
2009-01-29 17:27:54 +00:00
e96d88ff3d
fix another printf("%s", NULL) case
2009-01-29 17:18:24 +00:00
a10aa7a96b
correctly enable floppies for HVM guests.
2009-01-29 17:05:49 +00:00
3463c34e33
fix VNC port reporting when vncunused is set
2009-01-29 17:02:00 +00:00
bc18a91f91
error-reporting calls using VIR_ERR_NO_MEMORY: use virReportOOMError instead
...
* src/uml_conf.c (VIR_FROM_THIS): Define to VIR_FROM_UML.
* src/xs_internal.c (VIR_FROM_THIS): Define to VIR_FROM_XEN.
* src/xml.c (VIR_FROM_THIS): Define to VIR_FROM_XML.
* src/stats_linux.c (VIR_FROM_THIS): Define to VIR_FROM_STATS_LINUX.
* src/datatypes.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/lxc_conf.c (VIR_FROM_THIS): Define to VIR_FROM_LXC.
* src/libvirt.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
* src/node_device_conf.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/openvz_conf.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/openvz_driver.c (VIR_FROM_THIS): Define to VIR_FROM_OPENVZ.
* src/conf.c (VIR_FROM_THIS): Define to VIR_FROM_CONF.
Note: this loses config_filename:config_lineno diagnostics,
but that's ok.
* src/node_device.c (VIR_FROM_THIS): Define to VIR_FROM_NODEDEV.
* src/sexpr.c (VIR_FROM_THIS): Define to VIR_FROM_SEXPR.
* po/POTFILES.in: remove src/sexpr.c and src/lxc_conf.c
2009-01-29 12:10:32 +00:00
a99e5ccba4
don't abort if setlocale() fails
2009-01-29 11:49:33 +00:00
94d6177982
Fix typo & tweak variable decl
2009-01-28 22:07:36 +00:00
46d1324e47
Stopping reading off wire after 1 complete RPC message is received
2009-01-28 22:00:32 +00:00
e730de6fd8
remote_internal.c: fix typo that would mistakenly report OOM
...
* src/remote_internal.c (addrToString): Report VIR_ERR_UNKNOWN_HOST,
not VIR_ERR_NO_MEMORY.
2009-01-28 16:14:24 +00:00
8cc2bbe33c
qparams.c: Use virReportOOMError(NULL), not qparam_report_oom()
...
* src/qparams.c (VIR_FROM_THIS): Define to VIR_FROM_NONE.
(qparam_report_oom): Remove definition.
Replace all uses.
2009-01-28 16:13:46 +00:00
499189694a
fix mis-use of PF_UNIX as a protocol
2009-01-28 14:36:23 +00:00
489fde7680
Add support for copy-on-write storage volumes
2009-01-27 18:30:03 +00:00
f03d3439cd
virterror.c: don't read beyond end of buffer upon OOM
...
* src/virterror.c (virReportSystemErrorFull): Fix typo in
my previous change. Patch by Daniel P. Berrange.
2009-01-27 12:26:53 +00:00
b4f62abbf1
kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
...
IFF_VNET_HDR is a tun/tap flag that allows you to send and receive
large (i.e. GSO) packets and packets with partial checksums. Setting
the flag means that every packet is proceeded by the same header which
virtio uses to communicate GSO/csum metadata.
By enabling this flag on the tap fds we create, we greatly increase
the achievable throughput with virtio_net.
However, we need to be careful to only set the flag when a) QEMU has
support for this ABI and b) the value of the flag is queryable using
the TUNGETIFF ioctl.
It's nearly five months since kvm-74 - the first KVM release with this
feature - was released. Up until now, we've not added libvirt support
because there is no clean way to detect support for this in QEMU at
runtime. A brief attempt to add a "info capabilities" monitor command
to QEMU floundered. Perfect is the enemy of good enough. Probing the
KVM version will suffice for now.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
2009-01-27 11:12:05 +00:00
e15147c141
fix errors in virReportSystemErrorFull
...
* src/virterror.c (virStrerror): New function.
(virReportSystemErrorFull): Don't leak "combined".
In fact, don't even attempt allocation.
Do include the result of formatted print in final diagnostic.
2009-01-27 10:57:18 +00:00
339cc9d992
build: avoid format warnings
...
* src/proxy_internal.c (xenProxyCommand): Mark a diagnostic.
* src/xen_unified.c (xenUnifiedOpen, xenUnifiedAddDomainInfo):
Fix unmarked diagnostics by removing the diagnostic altogether:
replace each xenUnifiedError(...,VIR_ERR_NO_MEMORY call with a
call to virReportOOMError.
2009-01-27 08:50:03 +00:00
69d947eb80
* src/virterror.c (virErrorMsg): Correct indentation.
2009-01-27 08:49:15 +00:00
39e49ad7c9
fix recursive lock hang in xenstore driver
2009-01-23 19:18:24 +00:00
ad70b32414
Support QEMU disk format specification in XML
2009-01-23 16:22:20 +00:00
727d4fdc6e
fix comment typo: s/contains/continues/
...
* src/libvirt.c (virStorageVolFree): Correct typo in comment.
2009-01-23 14:18:43 +00:00
6278bb191a
maint: update list of error function names and adapt
...
* Makefile.maint (msg_gen_function): Update list.
Remove some now-unused names, add some new ones.
* src/hash.c (virHashError): Remove unused definition.
* src/openvz_conf.h (openvzLog): Likewise.
* src/xen_unified.c: Mark newly-exposed diagnostics for translation.
2009-01-23 12:29:29 +00:00
e80f10064e
parse IP address for bridge interfaces
2009-01-23 01:48:47 +00:00
c4985e9419
use the gnulib random_r function
2009-01-22 20:27:01 +00:00
1b745219c7
Remove use of non-reentrant POSIX apis
2009-01-22 19:41:48 +00:00
d0eab955c2
xm_internal.c: fix locking bug: s/Lock/Unlock/
...
* src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
try to acquire it) upon failure, just before returning.
2009-01-22 19:18:24 +00:00
7420fec81b
Remove non-existent symbol from linker script
2009-01-22 18:33:13 +00:00
fb4ec82358
Support script for bridge interface type
2009-01-22 18:29:13 +00:00
2b29698352
Least privilege support for Solaris
2009-01-22 17:49:41 +00:00
e52d74e536
Make xen driver threadsafe
2009-01-21 18:11:14 +00:00
e3672d9695
Allow storage driver to handle daemon restarts
2009-01-20 22:43:07 +00:00
23a090ab92
Allow virtual networks to survive daemon restart
2009-01-20 22:36:10 +00:00
a964a6dad6
Support ac97 soundcard model
2009-01-20 22:15:55 +00:00
5fb1e29c7e
* src/logging.c: fix openlog() ident lifetime for Solaris
...
daniel
2009-01-20 21:34:44 +00:00
a888b22cf9
Support domain events in test driver
2009-01-20 20:23:53 +00:00
3548e9aae8
don't ignore write failure
...
* src/network_driver.c (networkEnableIpForwarding): This function
would always return 1 (success). Now it returns 0 upon write or
close failure, being careful to preserve any errno from a write failure.
Add comments.
2009-01-20 19:29:08 +00:00
f61341173b
Allow concurrent processing of RPC calls in daemon
2009-01-20 19:25:15 +00:00
84ef468ba8
Fix some misleading comments in XM driver
2009-01-20 18:20:09 +00:00
2c7be88d15
Remove a use of strerror() in error reporting in remote driver
2009-01-20 17:47:13 +00:00
788bedd904
Remove use of static data in Xen XM driver
2009-01-20 17:34:56 +00:00
e428a69e6f
Remove use of static data in Xen inotify driver
2009-01-20 17:19:23 +00:00
437ac354fc
Make error reporting threadsafe by avoiding strerror
2009-01-20 17:13:33 +00:00
25415eb104
* src/qemu_driver.c: remove a warning when printing a file offset
...
daniel
2009-01-20 16:39:35 +00:00
61674cc17d
Make RPC call dispatch threaded
2009-01-20 16:36:34 +00:00
458a673cb7
remove stdout_fd, stderr_fd from virDomainObj
...
* src/domain_conf.h src/lxc_driver.c src/uml_driver.c: virDomainObj
doesn't need stdout and stderr fields anymore, patch from
Guido Günther
daniel
2009-01-20 16:10:20 +00:00
6d004d3f8a
* src/domain_conf.h src/qemu_driver.c: use monitor fd for QEmu/KVM
...
domain shutdown and read saved vm status on libvirtd startup,
last 2 patches from Guido Günther finishing up the surviving the
libvirt daemon restart
daniel
2009-01-20 15:52:11 +00:00
45062390a6
fix "make syntax-check" failures
...
* ChangeLog: Start with TAB, not 8 spaces.
* src/virterror.c: Remove trailing spaces.
2009-01-20 13:51:52 +00:00
a776fad370
Add public APIs for ref counting on public objects
2009-01-20 12:14:03 +00:00
ead04dcbe8
Thread local error reporting
2009-01-20 12:01:45 +00:00
c790f6d25e
Avoid bogus event loop wakeups in remote driver when doing RPC call
2009-01-20 11:45:09 +00:00
ed493909f7
Add locking to the remote driver
2009-01-20 11:41:24 +00:00
8dfbfe3145
daemonize qemu processes
2009-01-19 21:55:54 +00:00
5d99a309e6
save domstate as string in status file
2009-01-19 21:06:26 +00:00
9a969b86a9
* src/xen_internal.c src/xend_internal.c: Relax NUMA checking
...
for RHEL-5 and change the detection stategy for default Xen
accesses, patch by Markus Armbruster
daniel
2009-01-19 20:16:10 +00:00
b751b46bc5
Fix PVFB version check for RHEL-5
...
* src/xend_internal.c src/xm_internal.c: fix paravirt framebuffer
handling since it was backoprted for RHEL-5, patch by Markus
Armbruster
daniel
2009-01-19 19:49:30 +00:00
e676a699e8
* src/xend_internal.c src/xm_internal.c: fix fully virt network
...
device configuration for Xen on RHEL-5, patch by Markus Armbruster
daniel
2009-01-19 18:12:00 +00:00
99ed5b4bee
Two bug fixes coming from RHEL and Markus being added to AUTHORS
...
* src/xm_internal.c: two bug fixes coming from RHEL package
posted by Markus Armbruster
* AUTHORS: adding Markus
daniel
2009-01-19 15:24:41 +00:00
46d4a5e047
Fix segfault with console device back compat.
2009-01-16 16:50:11 +00:00
dd9b3fb594
Fix bug when fork isn't available (Win32) in remote driver
2009-01-15 20:13:12 +00:00
2be79b1d5e
Reduce exit paths in remote driver APIs
2009-01-15 20:07:10 +00:00
19d1bf2562
Remove use of macros in remote driver private data access
2009-01-15 20:04:44 +00:00
0cd119e7b8
Fix incorrect use of private data field in remote driver
2009-01-15 20:03:10 +00:00
4dac0a1105
Generic internal threads API
2009-01-15 19:56:05 +00:00
52e51d278e
Implement virKill for Win32 platform
2009-01-15 19:40:21 +00:00
4d713eabf5
Avoid passing NULL to printf %s specifier
2009-01-15 17:54:20 +00:00
c7095a4b4c
Improve xend_get error message
2009-01-15 15:17:53 +00:00
443698d2b2
implement capabilities parsing for Solaris
2009-01-15 01:35:17 +00:00
406c05f2e7
Fix xs_unwatch() to correctly pass the token
2009-01-15 01:23:32 +00:00
c8070bf632
Fix activeDomainList handling
2009-01-15 01:21:36 +00:00
65316d7940
Fix ref-counting for Xen driver event registration
2009-01-15 01:18:37 +00:00
5b6c39f51f
Mark Xen PV CD-ROM devices as such
2009-01-14 16:21:12 +00:00
6954d44e53
diagnose "libvirtd --config=no-such-file"
...
* qemud/qemud.c (remoteReadConfigFile): Don't return 0 (success)
when the config file is unreadable or nonexistent
Return -1, not 0, upon virConfReadFile failure.
(main): If remote_config_file is not specified via --config(-f),
use the default config file only if it exists. Otherwise,
use /dev/null.
* src/conf.c (virConfReadFile): Don't diagnose virFileReadAll
failure, since it already does that.
2009-01-12 18:22:32 +00:00
8af87ea251
don't emulate snprintf
2009-01-11 11:21:29 +00:00
4275be68fb
split out opening of the qemu logfile
2009-01-11 11:18:31 +00:00
261c3a8fd0
src/logging.h: fix non-debug compile
2009-01-09 19:22:02 +00:00
d6bd288da2
add missing flags argument
2009-01-08 19:52:15 +00:00
46971d5ed7
pass flags argument to all virDomain*DefParse* functions
2009-01-08 13:54:20 +00:00
c7cbbfa43b
* src/domain_conf.c src/qemu_conf.c: implement PCI passthrough
...
for recent KVM versions in a similar way to USB, patch by
Jason Krieg. Some cleanups and reformating too.
daniel
2009-01-07 12:56:13 +00:00
d6eceb568f
* src/openvz_driver.c: fix the mac addresses generation for OpenVZ veth
...
devices, patch by Evgeniy Sokolov
* docs/apps.html: regenerated fixing a typo
Daniel
2009-01-07 10:55:54 +00:00
fbba4423e9
* src/libvirt_private.syms src/qemu_driver.c src/test.c
...
src/uml_driver.c src/util.c src/util.h src/xen_unified.c:
unify hostname lookup using virGetHostname convenience function,
patch by David Lutterkort
daniel
2009-01-07 10:43:16 +00:00
37e72aa542
Fix misc mingw portability problems
2009-01-06 18:32:03 +00:00
83467de3ed
add virKillProcess
2009-01-06 17:46:46 +00:00
ffafc252dd
trivial cleanups
2009-01-06 17:20:27 +00:00
Daniel P. Berrange