Go to file
John Ferlan 2453501fc8 virsh: Track when create pkttyagent
https://bugzilla.redhat.com/show_bug.cgi?id=1374126

Due to how the processing for authentication using polkit works, the
virshConnect code must first "attempt" an virConnectOpenAuth and then
check for a "special" return error code VIR_ERR_AUTH_UNAVAILABLE in
order to attempt to "retry" the authentication after performing a creation
of a pkttyagent to handle the challenge/response for the client.

However, if pkttyagent creation is not possible for the authentication
being attempted (such as perhaps a "qemu+ssh://someuser@localhost/system"),
then the same failure pattern would be returned and another attempt to
create a pkttyagent would be done. This would continue "forever" until
someone forced quit (e.g. ctrl-c) from virsh as the 'authfail' was not
incremented when creating the pkttyagent.

So add a 'agentCreated' boolean to track if we've attempted to create the
agent at least once and force a failure if that creation returned the same
error pattern.

This resolves a possible never ending loop and will generate an error:

error: failed to connect to the hypervisor
error: authentication unavailable: no polkit agent available to authenticate action 'org.libvirt.unix.manage'

NB: If the authentication was for a sufficiently privileged client, such as
qemu+ssh://root@localhost/system, then the remoteDispatchAuthList "allows"
the authentication to use libvirt since @callerUid would be 0.
2017-05-25 12:19:20 -04:00
.gnulib@da830b5146 maint: update to latest gnulib 2017-05-15 16:13:03 +01:00
build-aux annotate all mocked functions with noinline 2017-04-19 10:51:51 +01:00
daemon daemonStreamHandleRead: Wire up seekable stream 2017-05-18 07:42:13 +02:00
docs docs: Update pointer to networking information 2017-05-22 13:22:32 +02:00
examples apparmor, virt-aa-helper: Explicit denies for host devices 2017-05-19 09:48:23 +02:00
gnulib build: drop hack for old mingw ssize_t 2016-07-12 08:57:13 -06:00
include/libvirt nodedev: Introduce new mdev_types and mdev nodedev capabilities 2017-05-18 12:20:15 +02:00
m4 locking: Add support for sanlock_strerror 2017-04-27 11:44:11 +02:00
po Release of libvirt-3.3.0 2017-05-05 21:38:00 +02:00
src qemu: Use correct variable in qemuDomainSetBlockIoTune 2017-05-25 14:25:23 +02:00
tests xenconfig: fix handling of NULL disk source 2017-05-19 08:47:36 -06:00
tools virsh: Track when create pkttyagent 2017-05-25 12:19:20 -04:00
.color_coded.in Add color_coded support 2017-05-09 09:51:11 +02:00
.ctags maint: Make ctags work out of the box 2013-07-18 08:47:21 +02:00
.dir-locals.el build: avoid tabs that failed syntax-check 2012-09-06 09:43:46 -06:00
.gitignore Add YouCompleteMe support 2017-05-09 09:51:11 +02:00
.gitmodules util: switch over to use keycodemapdb GIT submodule 2017-04-25 21:14:18 +01:00
.mailmap maint: update .mailmap for recent contributions 2015-03-20 06:17:55 -06:00
.travis.yml CI: show the log in case of failure 2017-05-25 08:58:39 +02:00
.ycm_extra_conf.py.in Add YouCompleteMe support 2017-05-09 09:51:11 +02:00
AUTHORS.in Change maintainers list 2016-02-12 13:10:05 +03:00
COPYING maint: follow recommended practice for using LGPL 2013-05-20 14:15:21 -06:00
COPYING.LESSER maint: Remove control characters from LGPL license file 2015-09-25 09:16:24 +02:00
ChangeLog-old Fix typos in src/* 2014-04-21 16:49:08 -06:00
HACKING HACKING: Document developer tooling 2017-05-09 09:51:11 +02:00
Makefile.am Provide a useful README file 2017-05-22 17:01:37 +01:00
Makefile.nonreentrant cfg.mk: use a single regex for all non-reentrant functions 2016-06-15 15:00:56 +02:00
README Provide a useful README file 2017-05-22 17:01:37 +01:00
README-hacking docs: update README-hacking 2014-05-06 16:20:24 -06:00
README.md Provide a useful README file 2017-05-22 17:01:37 +01:00
TODO Update todo list file to point at bugzilla/website 2010-10-13 16:45:26 +01:00
autogen.sh autogen.sh: Improve and generalize 2017-04-25 09:52:37 +02:00
bootstrap maint: update to latest gnulib 2017-01-10 12:54:54 -06:00
bootstrap.conf hvsupport: use a regex instead of XML::XPath 2016-07-19 18:42:44 +02:00
cfg.mk tests: Add virfilewrapper -- the new super "mock" 2017-05-09 13:12:40 +02:00
config-post.h m4/virt-devmapper: use LIBVIRT_CHECK_(PKG|LIB) 2016-12-21 15:39:39 +01:00
configure.ac test: fixing variable names for test suite inside configure.ac. 2017-05-22 06:14:02 +02:00
libvirt-admin.pc.in Add libvirt-admin library 2015-06-16 13:46:20 +02:00
libvirt-lxc.pc.in Add pkg-config files for libvirt-qemu & libvirt-lxc 2014-06-23 16:17:27 +01:00
libvirt-qemu.pc.in Add pkg-config files for libvirt-qemu & libvirt-lxc 2014-06-23 16:17:27 +01:00
libvirt.pc.in Add pkg-config files for libvirt-qemu & libvirt-lxc 2014-06-23 16:17:27 +01:00
libvirt.spec.in spec: Use HTTPS instead of HTTP 2017-05-11 18:35:45 +02:00
mingw-libvirt.spec.in spec: Use HTTPS instead of HTTP 2017-05-11 18:35:45 +02:00
run.in Add PKG_CONFIG_PATH to run.in script. 2014-06-26 14:32:35 +01:00

README.md

Build Status

Libvirt API for virtualization

Libvirt provides a portable, long term stable C API for managing the virtualization technologies provided by many operating systems. It includes support for QEMU, KVM, Xen, LXC, bhyve, Virtuozzo, VMware vCenter and ESX, VMware Desktop, Hyper-V, VirtualBox and the POWER Hypervisor.

For some of these hypervisors, it provides a stateful management daemon which runs on the virtualization host allowing access to the API both by non-privileged local users and remote users.

Layered packages provide bindings of the libvirt C API into other languages including Python, Perl, PHP, Go, Java, OCaml, as well as mappings into object systems such as GObject, CIM and SNMP.

Further information about the libvirt project can be found on the website:

License

The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General Public License, version 2.1 (or later). See the files COPYING.LESSER and COPYING for full license terms & conditions.

Installation

Libvirt uses the GNU Autotools build system, so in general can be built and installed with the usual commands. For example, to build in a manner that is suitable for installing as root, use:

$ ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var
$ make
$ sudo make install

While to build & install as an unprivileged user

$ ./configure --prefix=$HOME/usr
$ make
$ make install

The libvirt code relies on a large number of 3rd party libraries. These will be detected during execution of the configure script and a summary printed which lists any missing (optional) dependencies.

Contributing

The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list, using the git send-email command. Further guidance on this can be found in the HACKING file, or the project website

Contact

The libvirt project has two primary mailing lists:

Further details on contacting the project are available on the website