libvirt/src
Michal Privoznik 50c7a27244 qemu_monitor_json: Don't leak "option" in qemuMonitorJSONGetCommandLineOptions()
In recent commit of bf8bd93df0 (and friends) we switched the way
we process queried command line arguments: from string lists to
virJSONValue stored in a hash table. To achieve this
qemuMonitorJSONGetCommandLineOptions() helper was introduced
which executes the "query-command-line-options" monitor command
and then calls virJSONValueArrayForeachSteal() to process the
output. The array process function is also given
qemuMonitorJSONGetCommandLineOptionsWorker() as the callback
which is called over each item of the returned array. This
callback then steals "parameters" attribute of each array iteam
storing it in the hash table, but it leaves behind "option"
attribute (because it's g_strdup()-ed). After all of this, the
callback returns 0 which is a signal to the array processing
function that the callback took ownership of the array item. But
this is not true. While it removed "parameters" it did not take
the rest ("option" for instance). And therefore, it leads to a
memory leak:

 5,347 (1,656 direct, 3,691 indirect) bytes in 69 blocks are definitely lost in loss record 2,752 of 2,794
 at 0x483BEC5: calloc (vg_replace_malloc.c:760)
 by 0x4E25A10: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.6400.5)
 by 0x4943317: virJSONValueNewObject (virjson.c:569)
 by 0x4945692: virJSONParserHandleStartMap (virjson.c:1768)
 by 0x5825A86: yajl_do_parse (in /usr/lib64/libyajl.so.2.1.0)
 by 0x4945BFA: virJSONValueFromString (virjson.c:1896)
 by 0xAF5C115: qemuMonitorJSONIOProcessLine (qemu_monitor_json.c:224)
 by 0xAF5C45E: qemuMonitorJSONIOProcess (qemu_monitor_json.c:279)
 by 0xAF4BB6C: qemuMonitorIOProcess (qemu_monitor.c:342)
 by 0xAF4C444: qemuMonitorIO (qemu_monitor.c:574)
 by 0x4FEF846: socket_source_dispatch (in /usr/lib64/libgio-2.0.so.0.6400.5)
 by 0x4E1F727: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.6400.5)

The callback must return 1 so that the array item is properly
freed.

Fixes: ebeff6cd57
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2020-12-07 10:10:31 +01:00
..
access meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
admin meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
bhyve change DIR* int g_autoptr(DIR) where appropriate 2020-11-02 22:01:36 -05:00
conf domain_conf, qemu: move virDomainNVDimmAlignSizePseries to qemu_domain.c 2020-12-04 16:08:56 -03:00
cpu lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
cpu_map cpu_map: Fix Icelake Server model number 2020-12-04 12:56:19 +01:00
esx meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
hyperv hyperv: XML parsing of storage volumes 2020-11-24 18:45:07 +00:00
hypervisor util: hash: Retire 'virHashTable' in favor of 'GHashTable' 2020-11-06 10:40:51 +01:00
interface udevConnectListAllInterfaces: delete pointless cleanup code 2020-12-01 17:22:09 +01:00
keycodemapdb@27acf0ef82 keycodemapdb: update submodule for win32 keycode fix 2020-05-07 12:18:29 +01:00
libxl lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
locking locking: Resolve mem leak in virLockDaemonPreExecRestart 2020-12-02 16:15:43 +01:00
logging logging: Resolve mem leak in virLogDaemonPreExecRestart 2020-12-02 16:15:43 +01:00
lxc lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
network network: be more verbose about the reason for a firewall reload 2020-11-24 14:21:47 -05:00
node_device nodedev: report errors about missing integer properties 2020-11-17 16:55:07 +00:00
nwfilter util: hash: Retire 'virHashTable' in favor of 'GHashTable' 2020-11-06 10:40:51 +01:00
openvz openvzDomainMigratePrepare3Params: use g_auto 2020-11-19 15:21:59 +01:00
qemu qemu_monitor_json: Don't leak "option" in qemuMonitorJSONGetCommandLineOptions() 2020-12-07 10:10:31 +01:00
remote remote: make ssh-helper massively faster 2020-11-26 10:14:18 +00:00
rpc lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
secret secret: use g_new0 instead of VIR_ALLOC* 2020-10-01 12:34:13 +02:00
security apparmor: Drop needless check in AppArmorSetMemoryLabel() 2020-12-04 17:01:42 +01:00
storage lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
test virDomainCheckpointRedefineCommit: Don't check ABI of definition in checkpoint 2020-12-04 16:15:03 +01:00
util internal.h: Introduce and use VIR_IS_POW2() 2020-12-04 16:24:19 +01:00
vbox conf: add support for ESP SCSI controller family 2020-11-20 12:09:51 +00:00
vmware vmware: use g_new0 instead of VIR_ALLOC 2020-10-05 13:07:13 +02:00
vmx lib: Replace VIR_AUTOSTRINGLIST with GStrv 2020-12-02 15:43:07 +01:00
vz domain_conf: make virDomainDiskInsert() void 2020-11-11 12:53:11 +01:00
README Remove phyp driver 2019-12-20 12:25:42 -05:00
admin_protocol-structs admin: Introduce virAdmServerUpdateTlsFiles 2020-03-13 17:07:32 +00:00
datatypes.c src: make virObjectUnref return void 2020-06-03 10:20:17 +01:00
datatypes.h define g_autoptr cleanup function for virNetworkDHCPLease 2020-07-20 19:08:07 -04:00
driver-hypervisor.h virDomainAuthorizedSSHKeysSet: Use uint for @nkeys 2020-11-23 13:35:16 +01:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
driver-storage.h
driver-stream.h
driver.c util: use host module suffix when loading drivers 2020-08-26 10:30:18 +02:00
driver.h libvirt: support an "embed" URI path selector for opening drivers 2020-01-27 11:03:49 +00:00
internal.h internal.h: Introduce and use VIR_IS_POW2() 2020-12-04 16:24:19 +01:00
libvirt-domain-checkpoint.c Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE 2020-11-09 16:29:06 +00:00
libvirt-domain-snapshot.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-domain.c src: use singular form instead of plural, for guest disk info 2020-12-03 13:10:29 +00:00
libvirt-host.c Reduce scope of some variables 2020-09-24 11:19:06 +02:00
libvirt-interface.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-lxc.c libvirt-lxc: use g_autoptr for virCgroup 2020-10-09 16:24:40 +02:00
libvirt-lxc.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt-network.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-nodedev.c virsh: nodedev: ability to filter CSS capabilities 2020-09-15 09:06:24 +02:00
libvirt-nwfilter.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-qemu.c
libvirt-qemu.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt-secret.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-storage.c libvirt-storage: Document volume upload/download stream format 2020-08-24 13:32:53 +02:00
libvirt-stream.c src: libvirt-stream: use g_new0 instead of VIR_ALLOC* 2020-10-01 12:34:13 +02:00
libvirt.c libvirt: ensure defresult is used in virConnectAuthCallbackDefault 2020-09-22 16:43:47 +01:00
libvirt.conf
libvirt.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
libvirt_libssh.syms
libvirt_libssh2.syms
libvirt_linux.syms hostcpu: add support for reporting die_id in NUMA topology 2020-01-16 15:11:55 +00:00
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms domain_conf, qemu: move virDomainNVDimmAlignSizePseries to qemu_domain.c 2020-12-04 16:08:56 -03:00
libvirt_probes.d drop libdbus from libvirt 2020-09-17 18:20:33 +02:00
libvirt_public.syms Introduce OpenSSH authorized key file mgmt APIs 2020-11-18 16:18:25 +01:00
libvirt_qemu.syms
libvirt_remote.syms virnetdaemon: Wait for "daemon-stop" thread to finish before quitting 2020-11-24 17:52:54 +01:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms vmx: hide private helpers 2020-10-14 11:23:18 +02:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build meson: drop use of .path() for python args 2020-11-09 16:32:55 +00:00
qemu_protocol-structs
remote_protocol-structs remote: Implement OpenSSH authorized key file mgmt APIs 2020-11-18 16:18:25 +01:00
virkeepaliveprotocol-structs
virnetprotocol-structs

README

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories