mirror of https://gitee.com/openkylin/libvirt.git
93e8b8778a
Problem:
"parser.head" is not NULL even if it's free'ed by "virJSONValueFree",
returning "parser.head" when "virJSONValueFromString" fails will cause
unexpected errors (libvirtd will crash sometimes), e.g.
In function "qemuMonitorJSONArbitraryCommand":
if (!(cmd = virJSONValueFromString(cmd_str)))
goto cleanup;
if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0)
goto cleanup;
......
cleanup:
virJSONValueFree(cmd);
It will continues to send command to monitor even if "virJSONValueFromString"
is failed, and more worse, it trys to free "cmd" again.
Crash example:
{"error":{"class":"QMPBadInputObject","desc":"Expected 'execute' in QMP input","data":{"expected":"execute"}}}
{"error":{"class":"QMPBadInputObject","desc":"Expected 'execute' in QMP input","data":{"expected":"execute"}}}
error: server closed connection:
error: unable to connect to '/var/run/libvirt/libvirt-sock', libvirtd may need to be started: Connection refused
error: failed to connect to the hypervisor
This fix is to:
1) return NULL for failure of "virJSONValueFromString",
2) and it seems "virJSONValueFree" uses incorrect loop index for type
of "VIR_JSON_TYPE_OBJECT", fix it together.
* src/util/json.c
|
||
|---|---|---|
| .gnulib@c2090a84dc | ||
| daemon | ||
| docs | ||
| examples | ||
| include | ||
| m4 | ||
| po | ||
| python | ||
| src | ||
| tests | ||
| tools | ||
| .dir-locals.el | ||
| .gitignore | ||
| .gitmodules | ||
| .mailmap | ||
| .x-sc_avoid_ctype_macros | ||
| .x-sc_avoid_if_before_free | ||
| .x-sc_avoid_write | ||
| .x-sc_bindtextdomain | ||
| .x-sc_m4_quote_check | ||
| .x-sc_po_check | ||
| .x-sc_prohibit_HAVE_MBRTOWC | ||
| .x-sc_prohibit_VIR_ERR_NO_MEMORY | ||
| .x-sc_prohibit_always_true_header_tests | ||
| .x-sc_prohibit_asprintf | ||
| .x-sc_prohibit_close | ||
| .x-sc_prohibit_empty_lines_at_EOF | ||
| .x-sc_prohibit_fork_wrappers | ||
| .x-sc_prohibit_gethostby | ||
| .x-sc_prohibit_gethostname | ||
| .x-sc_prohibit_gettext_noop | ||
| .x-sc_prohibit_have_config_h | ||
| .x-sc_prohibit_nonreentrant | ||
| .x-sc_prohibit_readlink | ||
| .x-sc_prohibit_sprintf | ||
| .x-sc_prohibit_strncpy | ||
| .x-sc_prohibit_test_minus_ao | ||
| .x-sc_prohibit_xmlGetProp | ||
| .x-sc_require_config_h | ||
| .x-sc_require_config_h_first | ||
| .x-sc_trailing_blank | ||
| .x-sc_unmarked_diagnostics | ||
| AUTHORS | ||
| COPYING.LIB | ||
| ChangeLog-old | ||
| HACKING | ||
| Makefile.am | ||
| Makefile.nonreentrant | ||
| README | ||
| README-hacking | ||
| TODO | ||
| acinclude.m4 | ||
| autobuild.sh | ||
| autogen.sh | ||
| bootstrap | ||
| bootstrap.conf | ||
| cfg.mk | ||
| configure.ac | ||
| libvirt.pc.in | ||
| libvirt.spec.in | ||
| mingw32-libvirt.spec.in | ||
README
LibVirt : simple API for virtualization
Libvirt is a C toolkit to interact with the virtualization capabilities
of recent versions of Linux (and other OSes). It is free software
available under the GNU Lesser General Public License. Virtualization of
the Linux Operating System means the ability to run multiple instances of
Operating Systems concurrently on a single hardware system where the basic
resources are driven by a Linux instance. The library aim at providing
long term stable C API initially for the Xen paravirtualization but
should be able to integrate other virtualization mechanisms if needed.
Daniel Veillard <veillard@redhat.com>