mirror of https://gitee.com/openkylin/libvirt.git
![]() It doesn't make sense to fail if the SCSI host device is specified as "shareable" explicitly between domains (NB, it works if and only if the device is specified as "shareable" for *all* domains, otherwise it fails). To fix the problem, this patch introduces an array for virSCSIDevice struct, which records all the names of domain which are using the device (note that the recorded domains must specify the device as shareable). And the change on the data struct brings on many subsequent changes in the code. Prior to this patch, the "shareable" tag didn't work as expected, it actually work like "non-shareable". So this patch also added notes in formatdomain.html to declare the fact. * src/util/virscsi.h: - Remove virSCSIDeviceGetUsedBy - Change definition of virSCSIDeviceGetUsedBy and virSCSIDeviceListDel - Add virSCSIDeviceIsAvailable * src/util/virscsi.c: - struct virSCSIDevice: Change "used_by" to be an array; Add "n_used_by" as the array count - virSCSIDeviceGetUsedBy: Removed - virSCSIDeviceFree: frees the "used_by" array - virSCSIDeviceSetUsedBy: Copy the domain name to avoid potential memory corruption - virSCSIDeviceIsAvailable: New - virSCSIDeviceListDel: Change the logic, for device which is already in the list, just remove the corresponding entry in "used_by". And since it's only used in one place, we can safely removing the code to find out the dev in the list first. - Copyright updating * src/libvirt_private.sys: - virSCSIDeviceGetUsedBy: Remove - virSCSIDeviceIsAvailable: New * src/qemu/qemu_hostdev.c: - qemuUpdateActiveScsiHostdevs: Check if the device existing before adding it to the list; - qemuPrepareHostdevSCSIDevices: Error out if the not all domains use the device as "shareable"; Also don't try to add the device to the activeScsiHostdevs list if it already there; And make more sensible error w.r.t the current "shareable" value in driver->activeScsiHostdevs. - qemuDomainReAttachHostScsiDevices: Change the logic according to the changes on helpers. Signed-off-by: Osier Yang <jyang@redhat.com> |
||
---|---|---|
.. | ||
access | ||
conf | ||
cpu | ||
esx | ||
hyperv | ||
interface | ||
libxl | ||
locking | ||
lxc | ||
network | ||
node_device | ||
nwfilter | ||
openvz | ||
parallels | ||
phyp | ||
qemu | ||
remote | ||
rpc | ||
secret | ||
security | ||
storage | ||
test | ||
uml | ||
util | ||
vbox | ||
vmware | ||
vmx | ||
xen | ||
xenapi | ||
xenxs | ||
Makefile.am | ||
README | ||
check-aclperms.pl | ||
check-aclrules.pl | ||
check-driverimpls.pl | ||
check-drivername.pl | ||
check-symfile.pl | ||
check-symsorting.pl | ||
datatypes.c | ||
datatypes.h | ||
driver.c | ||
driver.h | ||
dtrace2systemtap.pl | ||
fdstream.c | ||
fdstream.h | ||
gnutls_1_0_compat.h | ||
internal.h | ||
libvirt-lxc.c | ||
libvirt-qemu.c | ||
libvirt.c | ||
libvirt.conf | ||
libvirt_atomic.syms | ||
libvirt_daemon.syms | ||
libvirt_driver_modules.syms | ||
libvirt_esx.syms | ||
libvirt_gnutls.syms | ||
libvirt_internal.h | ||
libvirt_libssh2.syms | ||
libvirt_linux.syms | ||
libvirt_lxc.syms | ||
libvirt_openvz.syms | ||
libvirt_private.syms | ||
libvirt_probes.d | ||
libvirt_public.syms | ||
libvirt_qemu.syms | ||
libvirt_qemu_probes.d | ||
libvirt_remote.syms | ||
libvirt_sasl.syms | ||
libvirt_vmware.syms | ||
libvirt_vmx.syms | ||
libvirt_xenxs.syms | ||
lock_protocol-structs | ||
lxc_monitor_protocol-structs | ||
lxc_protocol-structs | ||
nodeinfo.c | ||
nodeinfo.h | ||
nodeinfopriv.h | ||
qemu_protocol-structs | ||
remote_protocol-structs | ||
virkeepaliveprotocol-structs | ||
virnetprotocol-structs |
README
libvirt library code README =========================== The directory provides the bulk of the libvirt codebase. Everything except for the libvirtd daemon and client tools. The build uses a large number of libtool convenience libraries - one for each child directory, and then links them together for the final libvirt.so, although some bits get linked directly to libvirtd daemon instead. The files directly in this directory are supporting the public API entry points & data structures. There are two core shared modules to be aware of: * util/ - a collection of shared APIs that can be used by any code. This directory is always in the include path for all things built * conf/ - APIs for parsing / manipulating all the official XML files used by the public API. This directory is only in the include path for driver implementation modules * vmx/ - VMware VMX config handling (used by esx/ and vmware/) Then there are the hypervisor implementations: * esx/ - VMware ESX and GSX support using vSphere API over SOAP * hyperv/ - Microsoft Hyper-V support using WinRM * lxc/ - Linux Native Containers * openvz/ - OpenVZ containers using cli tools * phyp/ - IBM Power Hypervisor using CLI tools over SSH * qemu/ - QEMU / KVM using qemu CLI/monitor * remote/ - Generic libvirt native RPC client * test/ - A "mock" driver for testing * uml/ - User Mode Linux * vbox/ - Virtual Box using native API * vmware/ - VMware Workstation and Player using the vmrun tool * xen/ - Xen using hypercalls, XenD SEXPR & XenStore * xenapi/ - Xen using libxenserver Finally some secondary drivers that are shared for several HVs. Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers. The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all implement the secondary drivers directly * cpu/ - CPU feature management * interface/ - Host network interface management * network/ - Virtual NAT networking * nwfilter/ - Network traffic filtering rules * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers * storage/ - Storage management drivers Since both the hypervisor and secondary drivers can be built as dlopen()able modules, it is *FORBIDDEN* to have build dependencies between these directories. Drivers are only allowed to depend on the public API, and the internal APIs in the util/ and conf/ directories